save_analysis: fix some ICEs

[marmeladema]

Fixes #73020
Fixes #73022
Fixes #73041

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[marmeladema]

r? @Xanewok

[Xanewok]

Good catch, thanks!

@bors r+ rollup

[bors]

📌 Commit 84e4777 has been approved by Xanewok

[marmeladema]

Sorry @Xanewok i've just added a fix for another issue.

[Xanewok]

Do you think there are going to be more issues with TypeRelative paths being not matched on?

By the way you can try running the entire test suite with -Zsave-analysis passed to considerably increase the test set 😄

[marmeladema]

Potentially yes, but i've tried adding it everywhere and it leads to other bugs later on in librustc_middle so it will take a bit of time to understand how to do it properly.

In the mean time, those 2 commits should fix some ices/panics.

[marmeladema]

By the way you can try running the entire test suite with -Zsave-analysis passed to considerably increase the test set smile

That's what I am doing right now to find more crashes 👍 I hope to come back with some more patches in the next few days

[Xanewok]

That's good to hear! Let's try to land this, then:

@bors r+

[bors]

📌 Commit 4d6a307 has been approved by Xanewok

[RalfJung]

3 rollups failed with the same error and all contained this PR:
#73052, #73053, #73062
So, I think this is likely the culprit...
@bors r- rollup=never

[marmeladema]

Superseded by #73071

[RalfJung]

(Looks like that's just more commits added to this one, so IMO it would make sense to keep using the same PR so that all discussion is in one place. But whatever.^^)

[marmeladema]

The hope is that those new commits will magically fix those weird failures :-D

[RalfJung]

I understand. Still no reason to open a new PR -- to the contrary, opening a new PR erases the prior discussion and thus the relation to the previous failures.

But also, another rollup saw the same failures again and didn't include this PR. I am at a total loss where the problem is coming from.

[marmeladema]

I understand and I don't mind to let this PR open as a matter of fact. I thought it would be confusing to have two that includes the same commits.

[RalfJung]

Yes that's confusing indeed. So why did you open a 2nd one in the first place? You had a perfectly fine PR here, no reason to ditch it. :)

[marmeladema]

So @RalfJung let's go as originally planned. Can this be approved again? Or is there still suspicions this PR is breaking CI?

[Xanewok]

r=me with https://github.com/rust-lang/rust/pull/73046/files#r436305949 addressed

[Xanewok]

Thanks a lot! Let's try to get this in again...

@bors r+

[bors]

📌 Commit a7c18e0 has been approved by Xanewok

[Dylan-DPC-zz]

@bors p=1

[bors]

⌛ Testing commit a7c18e0 with merge 7355816...

[bors]

☀️ Test successful - checks-azure
Approved by: Xanewok
Pushing 7355816 to master...