save_analysis: various fixes #73071
save_analysis: various fixes #73071
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup=never |
|
This overlaps with #73046. I am at a loss as to why @marmeladema opened a second PR instead of continuing work on the first. But also, the strange issues are likely actually caused by some other PR, as a rollup without #73046 showed the same problem -- I guessed wrong when trying to figure out why the rollup broke. So the two extra commits here might or might not be needed. |
| value: make_signature(decl, generics), | ||
| value: fn_to_string( | ||
| decl, | ||
| hir::FnHeader { |
There was a problem hiding this comment.
That's unfortunate, together with importing rustc_target as a dependency...
I think this would be alleviated if we stored FnSig that has both FnHeader and FnDecl in ForeignItemKind::Fn and accessed that directly rather than just synthesizing the header (we lose the extern ABI information, in particular). The header is small and Copy so hopefully this doesn't impact things much...
Would such a change to HIR make sense? @RalfJung since you've already invested a bit of time in this PR series 😅
There was a problem hiding this comment.
Sorry I know nothing about HIR.^^
|
I opened a second PR because you commented on the first one saying it was responsible for the build failures and I hoped the additional commits might fix it. Sorry for the confusion, I am just trying to be helpful. Let's close this one for the time being. I'll rebase and re-open once #73046 is actually merged. |
It's okay, misunderstandings happen. :) |
Fixes #73020
Fixes #73022
Fixes #73041
r? @Xanewok
Once approved, could it be never rollup'ed? Because there was some strange issues happening on windows during CI.