Remove const prop for indirects #73130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't sound without validation. We don't want to report errors in case of failure to intern and validate, we just don't want to const prop. Interning and const prop is not built for this, let's not do it until we have a clearer picture on aggregate propagation.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 0acb30d990f8d083ef970b3cbc25ca5add42fdcb with merge cf6eb878bb583ffa3a9ea1219cdac97dffe23955... |
|
💔 Test failed - checks-azure |
bors
added
the
S-waiting-on-author
|
@bors try |
|
⌛ Trying commit 0acb30d990f8d083ef970b3cbc25ca5add42fdcb with merge afc2d6854e31cb3e2bc400a501281277a8bfde80... |
|
☀️ Try build successful - checks-azure |
|
Queued afc2d6854e31cb3e2bc400a501281277a8bfde80 with parent 7355816, future comparison URL. |
|
Finished benchmarking try commit (afc2d6854e31cb3e2bc400a501281277a8bfde80): comparison url. |
|
Looks like it doesn't make that much of a difference from a performance perspective so I'll just remove that now and maybe we can come back to it at some point in the future. |
wesleywiser
force-pushed
the
remove_const_prop_for_indirects
branch
from
0acb30d
to
fa41937
Compare
wesleywiser
changed the title
|
r? @oli-obk |
This comment has been minimized.
This comment has been minimized.
wesleywiser
force-pushed
the
remove_const_prop_for_indirects
branch
from
fa41937
to
1e88f13
Compare
JohnCSimon
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit 1e88f13 has been approved by |
bors
added
S-waiting-on-bors
This was referenced Jun 19, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#70740 (Enabling static-pie for musl) - rust-lang#72331 (Report error when casting an C-like enum implementing Drop) - rust-lang#72486 (Fix asinh of negative values) - rust-lang#72497 (tag/niche terminology cleanup) - rust-lang#72999 (Create self-contained directory and move there some of external binaries/libs) - rust-lang#73130 (Remove const prop for indirects) - rust-lang#73142 (Ensure std benchmarks get tested.) - rust-lang#73305 (Disallow loading crates with non-ascii identifier name.) - rust-lang#73346 (Add rust specific features to print target features) - rust-lang#73362 (Test that bounds checks are elided when slice len is checked up-front) - rust-lang#73459 (Reduce pointer casts in Box::into_boxed_slice) - rust-lang#73464 (Document format correction) - rust-lang#73479 (Minor tweaks to liballoc) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only used by one mir-opt test and since it causes buggy behavior under
-Zmir-opt-level=2, it seems like we should remove it.This was split out from #71946.
Closes #72679
Closes #72372
Closes #72285