Rollup of 7 pull requests #73168
Closed
Rollup of 7 pull requests #73168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular matching on complex types such as strings will cause deep recursion to happen. Fixes rust-lang#72933
I wasn't aware items _could_ be fake, so I think having a function mentioning it could be helpful. Also, I'd need to make this change for cross-crate intra-doc links anyway, so I figured it's better to make the refactor separate.
This causes unnecessary calls to `grow` when the allocation would fit exactly in the remaining space.
They are pointless. No reasonable allocator will be able to satisfy a `reserve_in_place` request that *doubles* the size of an allocation when dealing with allocations that are 4 KiB and larger. Just to be sure, I confirmed on Linux that the `reserve_in_place` calls never succeed. (Note however that the `reserve_in_place` call for `DroplessArena::grow` did occasionally succeed prior to the off-by-one fix in the previous commit, because we would sometimes do a `reserve_in_place` request for the chunk's current size, which would trivially succeed!)
Also remove a now-unnecessary `placement` argument.
- Use `len` more consistently for the number of elements in a vector, because that's the usual name. - Use `additional` more consistently for the number of elements we want to add, because that's what `Vec::reserve()` uses. - Use `cap` consistently rather than `capacity`. - Plus a few other tweaks. This increases consistency and conciseness.
…ace, r=Amanieu Remove `RawVec::reserve_in_place`. And some related clean-ups. r? @oli-obk
…i-obk Ensure stack when building MIR for matches In particular matching on complex types such as strings will cause deep recursion to happen. Fixes rust-lang#72933 r? @matthewjasper @oli-obk
…Gomez Add Item::is_fake for rustdoc I wasn't aware items _could_ be fake, so I think having a function mentioning it could be helpful. Also, I'd need to make this change for cross-crate intra-doc links anyway, so I figured it's better to make the refactor separate.
…an-DPC Clean up E0647 explanation r? @Dylan-DPC
Fix a typo (size of the size)
typo: awailable -> available
Add mailmap entry
|
@bors r+ rollup=never p=7 |
|
📌 Commit b044a95 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit b044a95 with merge 6f2ba8098b2e80ba50ceb2fb88b198b2c5519750... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit b044a95 with merge 6491ac9644ed562e8b7778e41016899397ac8f4a... |
|
@bors retry (cc @rust-lang/infra on another timeout) |
|
⌛ Testing commit b044a95 with merge 8d7caa787fb13e16e39165b913e7b80d5ebac55d... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
wasm failure looks spurious at the moment.. going to retry in a bigger rollup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
RawVec::reserve_in_place. #72417 (RemoveRawVec::reserve_in_place.)Failed merges:
r? @ghost