Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #73168

Closed
wants to merge 17 commits into from

Commits on Jun 3, 2020

  1. Ensure stack when building MIR for matches

    In particular matching on complex types such as strings will cause
    deep recursion to happen.
    
    Fixes rust-lang#72933
    nagisa committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    6b1ee67 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Add Item::is_fake for rustdoc

    I wasn't aware items _could_ be fake, so I think having a function
    mentioning it could be helpful. Also, I'd need to make this change for
    cross-crate intra-doc links anyway, so I figured it's better to make the
    refactor separate.
    jyn514 committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    1f11331 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Configuration menu
    Copy the full SHA
    f615582 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54fdb57 View commit details
    Browse the repository at this point in the history
  3. typo: awailable -> available

    cuviper committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    fd483c8 View commit details
    Browse the repository at this point in the history
  4. Fix off-by-one error in DroplessArena::alloc_raw.

    This causes unnecessary calls to `grow` when the allocation would fit
    exactly in the remaining space.
    nnethercote committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    5ceff6b View commit details
    Browse the repository at this point in the history
  5. Remove the reserve_in_place calls in {Typed,Dropless}Arena::grow.

    They are pointless. No reasonable allocator will be able to satisfy a
    `reserve_in_place` request that *doubles* the size of an allocation when
    dealing with allocations that are 4 KiB and larger.
    
    Just to be sure, I confirmed on Linux that the `reserve_in_place` calls
    never succeed.
    
    (Note however that the `reserve_in_place` call for `DroplessArena::grow`
    did occasionally succeed prior to the off-by-one fix in the previous
    commit, because we would sometimes do a `reserve_in_place` request for
    the chunk's current size, which would trivially succeed!)
    nnethercote committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    7145b87 View commit details
    Browse the repository at this point in the history
  6. Remove RawVec::reserve_in_place.

    Also remove a now-unnecessary `placement` argument.
    nnethercote committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    cb8bc8e View commit details
    Browse the repository at this point in the history
  7. Rename some identifiers in RawVec and libarena.

    - Use `len` more consistently for the number of elements in a vector,
      because that's the usual name.
    - Use `additional` more consistently for the number of elements we want
      to add, because that's what `Vec::reserve()` uses.
    - Use `cap` consistently rather than `capacity`.
    - Plus a few other tweaks.
    
    This increases consistency and conciseness.
    nnethercote committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    c9cbe7e View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Add mailmap entry

    tspiteri committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    aef6335 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#72417 - nnethercote:rm-RawVec-reserve_in_pl…

    …ace, r=Amanieu
    
    Remove `RawVec::reserve_in_place`.
    
    And some related clean-ups.
    
    r? @oli-obk
    Dylan-DPC committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    0f03fdd View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#72941 - nagisa:ensure-stack-for-match, r=ol…

    …i-obk
    
    Ensure stack when building MIR for matches
    
    In particular matching on complex types such as strings will cause
    deep recursion to happen.
    
    Fixes rust-lang#72933
    
    r? @matthewjasper @oli-obk
    Dylan-DPC committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    fc44861 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#73098 - jyn514:rustdoc-is-fake, r=Guillaume…

    …Gomez
    
    Add Item::is_fake for rustdoc
    
    I wasn't aware items _could_ be fake, so I think having a function
    mentioning it could be helpful. Also, I'd need to make this change for
    cross-crate intra-doc links anyway, so I figured it's better to make the
    refactor separate.
    Dylan-DPC committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    a57e823 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#73123 - GuillaumeGomez:cleanup-e0647, r=Dyl…

    …an-DPC
    
    Clean up E0647 explanation
    
    r? @Dylan-DPC
    Dylan-DPC committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    2adefb3 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73148 - DarkEld3r:patch-1, r=jonas-schievink

    Fix a typo (size of the size)
    Dylan-DPC committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    b9b464b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73149 - cuviper:awailable, r=steveklabnik

    typo: awailable -> available
    Dylan-DPC committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    c31122e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b044a95 View commit details
    Browse the repository at this point in the history