Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #73316

Merged
merged 18 commits into from
Jun 13, 2020
Merged

Rollup of 8 pull requests #73316

merged 18 commits into from
Jun 13, 2020

Commits on Jun 2, 2020

  1. Configuration menu
    Copy the full SHA
    4548eb8 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Configuration menu
    Copy the full SHA
    57b54c4 View commit details
    Browse the repository at this point in the history
  2. Helper method for whether type has structural equality

    This helper method works for all types, falling back to a query for
    `TyKind::Adt`s to determine whether the implement the
    `{Partial,}StructuralEq` traits.
    ecstatic-morse committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    bd4bd59 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1dd4561 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2801761 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b126f32 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Configuration menu
    Copy the full SHA
    c755292 View commit details
    Browse the repository at this point in the history
  2. Adjusted some doctests in libcore to use should_panic.

    Previously, some doctests were spawning new threads and joining them to
    indicate that a particular call should panic; this hurt readability, so
    the tests have been adjusted to simply call the method and use the
    `should_panic` marker.
    Jake Degen authored and JakobDegen committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    3ab4b38 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    249a46f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5a841b9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72932 - poliorcetics:pattern-contains-behav…

    …iour, r=hanna-kruppe
    
    Clarify the behaviour of Pattern when used with methods like str::contains
    
    Fixes rust-lang#45507.
    
    I used the previous work by @Emerentius (thanks !), added a paragraph and checked the links (they work for me but I'm not against someone else checking them too).
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    2cc2672 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73066 - ecstatic-morse:query-structural-eq2…

    …, r=pnkfelix
    
    Querify whether a type has structural equality (Take 2)
    
    Alternative to rust-lang#72177.
    
    Unlike in rust-lang#72177, this helper method works for all types, falling back to a query for `TyKind::Adt`s that determines whether the `{Partial,}StructuralEq` traits are implemented.
    
    This is my preferred interface for this method. I think this is better than just documenting that the helper only works for ADTs. If others disagree, we can just merge rust-lang#72177 with the fixes applied. This has already taken far too long.
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    6ad8cbd View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73194 - lzutao:INT-patterns, r=dtolnay

    Prefer the associated constants for pattern matching error
    
    Resolved this comment: rust-lang#68490 (comment)
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    f738423 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73241 - mati865:mingw-libs-order-comment, r…

    …=petrochenkov
    
    Add/update comments about MinGW late_link_args
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    61a59a5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73267 - ehuss:cargotest-this-cargo, r=Mark-…

    …Simulacrum
    
    Use the built cargo for cargotest.
    
    cargotest was using the beta (bootstrap) cargo. This changes it so that it will use the locally built cargo. This is intended to provide a sort of smoke test to ensure Cargo is functional. This *shouldn't* have any real impact on the CI build time.  The cargotest job also happens to run cargo's testsuite, so it should already be building cargo.
    
    Note: This will fail until rust-lang#73266 is merged.
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    6a42f7d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73290 - LeSeulArtichaut:patch-1, r=Dylan-DPC

    Fix links when pinging notification groups
    
    I think a blank line is necessary for the link to be applied.
    Not sure who to assign, r? @Dylan-DPC
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    0bbc651 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#73302 - JakobDegen:should-panic-documentati…

    …on, r=Mark-Simulacrum
    
    Adjusted some doctests in libcore to use `should_panic`.
    
    Fixes rust-lang#73196 .
    
    I grepped libstd and libcore for all the instances of this pattern that I could find, but its possible that I missed some of course. If anyone knows of any more, please let me know and I will add them to the PR.
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    a879f9c View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…

    …rch64, r=Amanieu
    
    pretty/asm.rs should only be tested for x86_64 and not AArch64
    
    pretty/asm.rs should only be tested for x86_64 and not AArch64
    closes rust-lang#73134
    r?  @Amanieu
    Dylan-DPC committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    8d97ccf View commit details
    Browse the repository at this point in the history