Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note numeric literals that can never fit in an expected type #73334

Merged
merged 5 commits into from
Jun 20, 2020

Commits on Jun 13, 2020

  1. Note numeric literals that can never fit in an expected type

    re rust-lang#72380 (comment)
    
    Given the toy code
    
    ```rust
    fn is_positive(n: usize) {
      n > -1_isize;
    }
    ```
    
    We currently get a type mismatch error like the following:
    
    ```
    error[E0308]: mismatched types
     --> src/main.rs:2:9
      |
    2 |     n > -1_isize;
      |         ^^^^^^^^ expected `usize`, found `isize`
      |
    help: you can convert an `isize` to `usize` and panic if the converted value wouldn't fit
      |
    2 |     n > (-1_isize).try_into().unwrap();
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ```
    
    But clearly, `-1` can never fit into a `usize`, so the suggestion will
    always panic. A more useful message would tell the user that the value
    can never fit in the expected type:
    
    ```
    error[E0308]: mismatched types
     --> test.rs:2:9
      |
    2 |     n > -1_isize;
      |         ^^^^^^^^ expected `usize`, found `isize`
      |
    note: `-1_isize` can never fit into `usize`
     --> test.rs:2:9
      |
    2 |     n > -1_isize;
      |         ^^^^^^^^
    ```
    
    Which is what this commit implements.
    
    I only added this check for negative literals because
    
    - Currently we can only perform such a check for literals (constant
      value propagation is outside the scope of the typechecker at this
      point)
    - A lint error for out-of-range numeric literals is already emitted
    
    IMO it makes more sense to put this check in librustc_lint, but as far
    as I can tell the typecheck pass happens before the lint pass, so I've
    added it here.
    
    r? @estebank
    ayazhafiz committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    afbbd38 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Configuration menu
    Copy the full SHA
    2b936bb View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Configuration menu
    Copy the full SHA
    f0d3689 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Configuration menu
    Copy the full SHA
    d7277df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a89a33 View commit details
    Browse the repository at this point in the history