Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #73499

Closed
wants to merge 31 commits into from

Commits on Jun 13, 2020

  1. Speed up bootstrap a little.

    ehuss committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    0687b78 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Add rust features to print target features

    `crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there.
    aszenz committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    e32db84 View commit details
    Browse the repository at this point in the history
  2. Switch bootstrap metadata to --no-deps.

    This should run much faster.
    
    There are also some drive-by cleanups here to try to simplify things.
    Also, the paths for in-tree crates are now displayed as relative
    in `x.py test -h -v`.
    ehuss committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    607e851 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c2b920f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Configuration menu
    Copy the full SHA
    f17fd7b View commit details
    Browse the repository at this point in the history
  2. bootstrap/install.rs: support a nonexistent prefix in x.py install

    PR rust-lang#49778 introduced fs::canonicalize() which fails for a nonexistent path.
    This is a surprise for someone used to GNU Autotools' configure which can create any necessary intermediate directories in prefix.
    
    This change makes it run fs::create_dir_all() before canonicalize().
    nodakai committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    8e7606f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4eef51a View commit details
    Browse the repository at this point in the history
  4. Cache flags and escaping vars for predicates

    Also hash predicates by address
    matthewjasper committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    4709f45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2e17245 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a4337cc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc13fd0 View commit details
    Browse the repository at this point in the history
  8. Only display other method receiver candidates if they actually apply

    Previously, we would suggest `Box<Self>` as a valid receiver, even if
    method resolution only succeeded due to an autoderef (e.g. to `&self`)
    Aaron1011 committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    8956a7f View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. lint: normalize projections using opaque types

    This commit normalizes projections which contain opaque types (opaque types
    are otherwise linted against, which is would have previously made the
    test cases added in this commit fail).
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    792bd3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a19dfb5 View commit details
    Browse the repository at this point in the history
  3. Update ui tests

    GuillaumeGomez committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    bad252c View commit details
    Browse the repository at this point in the history
  4. Update CFGuard syntax

    ajpaverd committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    83e6c0e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4506a35 View commit details
    Browse the repository at this point in the history
  6. break long line for formatting

    aszenz committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    9f50f84 View commit details
    Browse the repository at this point in the history
  7. trim whitespace

    aszenz committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    457acbd View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. add blank line bw sections

    Separate target features from rust ones with a blank line
    
    Co-authored-by: Josh Stone <cuviper@gmail.com>
    aszenz and cuviper committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    caffb28 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Configuration menu
    Copy the full SHA
    f633dd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Rollup merge of rust-lang#73180 - matthewjasper:predicate-cache, r=ni…

    …komatsakis
    
    Cache flags and escaping vars for predicates
    
    With predicates becoming interned (rust-lang/compiler-team#285) this is now possible and could be a perf win. It would become an even larger win once we have recursive predicates.
    
    cc @lcnr @nikomatsakis
    
    r? @ghost
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    1189841 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b50373 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#73287 - davidtwco:issue-73251-opaque-types-…

    …in-projections, r=estebank
    
    lint: normalize projections using opaque types
    
    Fixes rust-lang#73251.
    
    This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    43fc34c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#73300 - crlf0710:crate_level_only_check, r=…

    …petrochenkov
    
    Implement crate-level-only lints checking.
    
    This implements a crate_level_only flag on lints, and when it is true, it becomes an error when user tries  to specify this flag upon nodes other than crate node.
    
    This also turns on this flag for all non_ascii_ident lints.
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2faa2a2 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#73346 - aszenz:patch-1, r=cuviper

    Add rust specific features to print target features
    
    Fixes rust-lang#71583
    
    `crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there so that it shows under `rustc --print target-features`.
    
    Probably the most native implementation I could think of, would love to get feedback.
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    1dfba21 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73350 - nodakai:install-rs-support-nonexist…

    …ent-prefix, r=Mark-Simulacrum
    
    bootstrap/install.rs: support a nonexistent `prefix` in `x.py install`
    
    PR rust-lang#49778 introduced fs::canonicalize() which fails for a nonexistent path.
    This is a surprise for someone used to GNU Autotools' configure which can create any necessary intermediate directories in prefix.
    
    This change makes it run fs::create_dir_all() before canonicalize().
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    50a7dce View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73352 - ehuss:bootstrap-metadata, r=Mark-Si…

    …mulacrum
    
    Speed up bootstrap a little.
    
    The bootstrap script was calling `cargo metadata` 3 times (or 6 with `-v`). This is a very expensive operation, and this attempts to avoid the extra calls. On my system, a simple command like `./x.py test -h -v` goes from about 3 seconds to 0.4.
    
    An overview of the changes:
    
    - Call `cargo metadata` only once with `--no-deps`. Optional dependencies are filtered in `in_tree_crates` (handling `profiler_builtins` and `rustc_codegen_llvm` which are driven by the config).
    - Remove a duplicate call to `metadata::build` when using `-v`. I'm not sure why it was there, it looks like a mistake or vestigial from previous behavior.
    - Remove check for `_shim`, I believe all the `_shim` crates are now gone.
    - Remove check for `rustc_` and `*san` for `test::Crate::should_run`, these are no longer dependencies in the `test` tree.
    - Use relative paths in `./x.py test -h -v` output.
    - Some code cleanup (remove unnecessary `find_compiler_crates`, etc.).
    - Show suite paths (`src/test/ui/...`) in `./x.py test -h -v` output.
    - Some doc comments.
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2ec6bf0 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73357 - petrochenkov:tmap, r=davidtwco

    Use `LocalDefId` for import IDs in trait map
    
    cc rust-lang#73291 (comment)
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    3e4140d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73382 - Aaron1011:fix/self-receiver-candida…

    …tes, r=petrochenkov
    
    Only display other method receiver candidates if they actually apply
    
    Previously, we would suggest `Box<Self>` as a valid receiver, even if
    method resolution only succeeded due to an autoderef (e.g. to `&self`)
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    fc3e911 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73404 - ajpaverd:cfguard_syntax, r=Mark-Sim…

    …ulacrum
    
    Update CFGuard syntax
    
    Update the naming and syntax of the control-flow-guard option, as discussed in rust-lang#68793.
    
    r? @Mark-Simulacrum
    Manishearth committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    dc3ca0f View commit details
    Browse the repository at this point in the history