Revert PR #72389 - "Explain move errors that occur due to method calls involving self"
#73594
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Thanks! |
|
📌 Commit 2959352 has been approved by |
bors
added
S-waiting-on-bors
|
(Would be nice when revert PR descriptions contain at least a link to where the explanation is for why a revert is needed.) |
|
@bors p=5 This is blocking a whole chain of intra doc link fixes and stabilization |
…r=petrochenkov Revert PR rust-lang#72389 - "Explain move errors that occur due to method calls involving `self" r? @petrochenkov
|
⌛ Testing commit 2959352 with merge c0f4ee5d0e06d500b4cfd4bf19fcf4ee97707f89... |
|
My bad, this is blocking clippy test syncs, a different problem that is also high priority as right now clippy tests aren't being CId 😄 |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
|
So it's failing to compile the proc macro aux file. Unclear why. Feel free to temporarily remove the test and land this while we figure it out. I was unable to get that failure to happen locally with an RTIM-rustc, might try full build tomorrow |
|
@Manishearth I'm able to reproduce the UI-test failure with |
None of the tools seem to need syn 0.15.35, so we can just build syn 1.0. This was causing an issue with clippy's `compile-test` program: since multiple versions of `syn` would exist in the build directory, we would non-deterministically pick one based on filesystem iteration order. If the pre-1.0 version of `syn` was picked, a strange build error would occur (see rust-lang#73594 (comment)) To prevent this kind of issue from happening again, we now panic if we find multiple versions of a crate in the build directly, instead of silently picking the first version we find.
Aaron1011
force-pushed
the
revert/move-fn-self-msg
branch
from
2959352
to
e2ab98d
Compare
|
@Manishearth @flip1995: I found the cause of the error - we had multiple versions of This should be ready to merge. |
|
@bors r+ |
|
📌 Commit e2ab98d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
None of the tools seem to need syn 0.15.35, so we can just build syn 1.0. This was causing an issue with clippy's `compile-test` program: since multiple versions of `syn` would exist in the build directory, we would non-deterministically pick one based on filesystem iteration order. If the pre-1.0 version of `syn` was picked, a strange build error would occur (see rust-lang/rust#73594 (comment)) To prevent this kind of issue from happening again, we now panic if we find multiple versions of a crate in the build directly, instead of silently picking the first version we find.
This is a re-attempt of rust-lang#72389 (which was reverted in rust-lang#73594) Instead of using `ExpnKind::Desugaring` to represent operators, this PR checks the lang item directly.
This is a re-attempt of rust-lang#72389 (which was reverted in rust-lang#73594) Instead of using `ExpnKind::Desugaring` to represent operators, this PR checks the lang item directly.
…lf-msg, r=davidtwco Explain move errors that occur due to method calls involving `self` (take two) This is a re-attempt of rust-lang#72389 (which was reverted in rust-lang#73594) Instead of using `ExpnKind::Desugaring` to represent operators, this PR checks the lang item directly.
|
This was a perf win of up to 3.1% on a few benchmarks. |
nnethercote
changed the title
self"
reverts #72389
r? @petrochenkov