Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative path for local links to primitives #74077

Merged
merged 9 commits into from
Jul 10, 2020

Commits on Jul 6, 2020

  1. Use relative path for local links to primitives in libcore

    Else, links to `char::foo` would point into `/path/to/src/libcore/std/primitive.char.html#method.foo`.
    
    Split out from rust-lang#73804.
    sethp committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    81fbfc4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee3a0f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Two new rustdoc tests for intra links

    They both produce less-than-desirable output (links going to docs.rust-lang.org), but I haven't figured out yet how to assert about them properly.
    sethp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    33a5d00 View commit details
    Browse the repository at this point in the history
  2. build extern docs as well

    sethp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    165aecb View commit details
    Browse the repository at this point in the history
  3. Assert current behavior for links

    For the two of these tests that have a local `char` to link to, this behavior isn't what's expected, but is what's happening presently.
    sethp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    865b930 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f258d98 View commit details
    Browse the repository at this point in the history
  5. Revert "Add guard to check for local core crate"

    This reverts commit ee3a0f8.
    sethp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8d267db View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Configuration menu
    Copy the full SHA
    9366458 View commit details
    Browse the repository at this point in the history
  2. Avoid running test on Windows platforms

    There don't seem to be any other compiletests that are 1) building a standalone "no_core" create and then 2) trying to link against it. There seems to be a platform-specific limitation in doing so:
    
    ```
    2020-07-08T16:07:42.9419409Z   = note:    Creating library D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll.lib and object D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll.exp
    2020-07-08T16:07:42.9419810Z           LINK : error LNK2001: unresolved external symbol __DllMainCRTStartup@12
    2020-07-08T16:07:42.9420032Z           D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll : fatal error LNK1120: 1 unresolved externals
    ```
    
    Possibly this could be resolved by adding a `__DllMainCRTStartup` or `__DllMainCRTStartup@12` symbol in an architecture- and platform-specific way.
    sethp committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    56b6b44 View commit details
    Browse the repository at this point in the history