Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] perf-test for #74071 #74596

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] perf-test for #74071 #74596

wants to merge 2 commits into from

Conversation

rust-timer
Copy link
Collaborator

This is an automatically generated pull request (from here) to run perf tests for #74071 which merged in a rollup.

r? @ghost

@rust-timer
Revert to 1fa54ad
9c88e94
@rust-timer
rust-timer simulated merge of 43ba840
c560fc8 
Original message:
Rollup merge of rust-lang#74071 - petrochenkov:cload3, r=matthewjasper

rustc_metadata: Make crate loading fully speculative

Instead of reporting `span_err`s on the spot crate loading errors are now wrapped into the `CrateError` enum and returned, so they are reported only at the top level `resolve_crate` call, and not reported at all if we are resolving speculatively with `maybe_resolve_crate`.

As a result we can attempt loading crates for error recovery (e.g. import suggestions) without any risk of producing extra errors.
Also, this means better separation between error reporting and actual logic.

Fixes rust-lang#55103
Fixes rust-lang#56590
@rust-timer
Copy link
Collaborator Author

@bors try @rust-timer queue

The try commit's (master) parent should be 8ad7bc3. If it isn't, then please:

  • Stop this try build (try-).
  • Run @rust-timer update-pr-for 43ba8409d7c7f93d6f0b3c22fe1b193788ff6162.
  • Rerun bors try.

You do not need to reinvoke the queue command as long as the perf build hasn't yet started.

@rust-timer
Copy link
Collaborator Author

Awaiting bors try build completion

@Mark-Simulacrum
Copy link
Member

1 second is seemingly not enough, so upped to 30 seconds of waiting before we post the try build comment. @bors try

@bors
Copy link
Contributor

bors commented Jul 21, 2020

⌛ Trying commit c560fc8 with merge fc4fbd1d24fb634a895e2f39f495cb3d0a2472d6...

@bors
Copy link
Contributor

bors commented Jul 21, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: fc4fbd1d24fb634a895e2f39f495cb3d0a2472d6 (fc4fbd1d24fb634a895e2f39f495cb3d0a2472d6)

@rust-timer
Copy link
Collaborator Author

Queued fc4fbd1d24fb634a895e2f39f495cb3d0a2472d6 with parent 8ad7bc3, future comparison URL.

@rust-timer
Copy link
Collaborator Author

Finished benchmarking try commit (fc4fbd1d24fb634a895e2f39f495cb3d0a2472d6): comparison url.

                Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying `rollup-` to bors.

                Importantly, though, if the results of this run are non-neutral **do not** roll this PR up -- it will mask other regressions or improvements in the roll up.

                @bors rollup=never

@Mark-Simulacrum
Copy link
Member

Correct link: https://perf.rust-lang.org/compare.html?start=1fa54ad9680cc82e7301f8ed4e9b7402dfd6ce0e&end=fc4fbd1d24fb634a895e2f39f495cb3d0a2472d6

Performance-neutral.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rust-timer @Mark-Simulacrum @bors