Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PGO tests on Windows-gnu #75184

Closed
wants to merge 1 commit into from
Closed

Enable PGO tests on Windows-gnu #75184

wants to merge 1 commit into from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 5, 2020 •
edited

Closes #61266

This will enable 10 tests (those with needs-profiler-support), the time they take should be marginal but I can add it to try first if you want.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2020
@mati865
Copy link
Contributor Author

mati865 commented Aug 5, 2020

@bors rollup=iffy
I have no idea if it still works with old compiler on CI.

@bors
Copy link
Contributor

bors commented Aug 5, 2020

@mati865: 🔑 Insufficient privileges: not in try users

@JohnTitor
Copy link
Member

Let's re-assigning as this hasn't got any response for about two weeks, r? @petrochenkov I guess you're familiar with it?

@JohnTitor JohnTitor assigned petrochenkov and unassigned kennytm Aug 19, 2020
@petrochenkov
Copy link
Contributor

If it passes through CI, then it's good.
@bors r+

@bors
Copy link
Contributor

bors commented Aug 20, 2020

📌 Commit 6ad174d has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020
@bors
Copy link
Contributor

bors commented Aug 21, 2020

⌛ Testing commit 6ad174d with merge e43e4f2b9e6b2e2b312370ed2e64fcb84663389b...

@bors
Copy link
Contributor

bors commented Aug 21, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2020
@petrochenkov
Copy link
Contributor 

failures:
    [run-make] run-make-fulldeps\instrument-coverage
    [run-make] run-make-fulldeps\pgo-branch-weights
    [run-make] run-make-fulldeps\pgo-indirect-call-promotion
    [run-make] run-make-fulldeps\pgo-use

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2020
@mati865
Copy link
Contributor Author

mati865 commented Aug 21, 2020

Works with ld.lld, fails with ld.bfd. I'll close that for now.

@mati865 mati865 closed this Aug 21, 2020
@mati865 mati865 mentioned this pull request Aug 24, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
@Dylan-DPC
Rollup merge of rust-lang#75872 - mati865:pgo-tests, r=petrochenkov
27a571f 
Enable some of profiler tests on Windows-gnu

CC rust-lang#61266

Because of force-push GitHub didn't let me reopen rust-lang#75184

Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI.
However we can still test the IR for the proper instrumentation so let's do it.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
@Dylan-DPC
Rollup merge of rust-lang#75872 - mati865:pgo-tests, r=petrochenkov
9178eb0 
Enable some of profiler tests on Windows-gnu

CC rust-lang#61266

Because of force-push GitHub didn't let me reopen rust-lang#75184

Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI.
However we can still test the IR for the proper instrumentation so let's do it.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2020
@bors
Auto merge of rust-lang#75872 - mati865:pgo-tests, r=petrochenkov
04f44fb 
Enable some of profiler tests on Windows-gnu

CC rust-lang#61266

Because of force-push GitHub didn't let me reopen rust-lang#75184

Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI.
However we can still test the IR for the proper instrumentation so let's do it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable PGO tests on windows-gnu
6 participants
@mati865 @rust-highfive @bors @JohnTitor @petrochenkov @kennytm