Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SGX RWLock initializer test #76278

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Improve SGX RWLock initializer test #76278

merged 1 commit into from
Sep 14, 2020

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Sep 3, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2020
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 4, 2020
@jethrogb
Copy link
Contributor Author

jethrogb commented Sep 8, 2020

Ping for review?

@jethrogb jethrogb mentioned this pull request Sep 14, 2020
Closed
@Mark-Simulacrum
Copy link
Member

This looks relatively reasonable. It also is SGX-only.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 14, 2020

📌 Commit 0b5e681 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2020
@bors
Copy link
Contributor

bors commented Sep 14, 2020

⌛ Testing commit 0b5e681 with merge bb0067c...

@bors
Copy link
Contributor

bors commented Sep 14, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing bb0067c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 14, 2020
@bors bors merged commit bb0067c into rust-lang:master Sep 14, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 14, 2020
@jethrogb
Copy link
Contributor Author

jethrogb commented Sep 15, 2020 •
edited

I don't mind this being merged but the point was to get a review from someone who understands uninitialized memory. ¯\_(ツ)_/¯

@workingjubilee workingjubilee added the O-SGX Target: SGX label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-SGX Target: SGX S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Reduce uninitialized memory trickery in RWLock C interface test
8 participants
@jethrogb @Mark-Simulacrum @bors @eddyb @rust-highfive @jyn514 @workingjubilee @rustbot