Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up vec benches bench_in_place style #76400

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Clean up vec benches bench_in_place style #76400

merged 1 commit into from
Sep 19, 2020

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Sep 6, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Sep 6, 2020 •
edited
Loading

@pickfire change test::Bencher to Bencher and mem::take to mem::replace and rand::RngCore import and LEN = 16384 (and pos) and once instead of [0].iter() after this.

@dtolnay
Copy link
Member

dtolnay commented Sep 19, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 19, 2020

📌 Commit 685f042 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 19, 2020
@RalfJung
Rollup merge of rust-lang#76400 - pickfire:patch-5, r=dtolnay
0d80a97 
Clean up vec benches bench_in_place style
@RalfJung
Copy link
Member

@bors rollup

@RalfJung RalfJung mentioned this pull request Sep 19, 2020
Closed
@RalfJung RalfJung mentioned this pull request Sep 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2020
@bors
Auto merge of rust-lang#76912 - RalfJung:rollup-q9ur56h, r=RalfJung
8e9d5db 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#73963 (deny(unsafe_op_in_unsafe_fn) in libstd/path.rs)
 - rust-lang#75099 (lint/ty: move fns to avoid abstraction violation)
 - rust-lang#75502 (Use implicit (not explicit) rules for promotability by default in `const fn`)
 - rust-lang#75580 (Add test for checking duplicated branch or-patterns)
 - rust-lang#76310 (Add `[T; N]: TryFrom<Vec<T>>` (insta-stable))
 - rust-lang#76400 (Clean up vec benches bench_in_place style)
 - rust-lang#76434 (do not inline black_box when building for Miri)
 - rust-lang#76492 (Add associated constant `BITS` to all integer types)
 - rust-lang#76525 (Add as_str() to string::Drain.)
 - rust-lang#76636 (assert ScalarMaybeUninit size)
 - rust-lang#76749 (give *even better* suggestion when matching a const range)
 - rust-lang#76757 (don't convert types to the same type with try_into (clippy::useless_conversion))
 - rust-lang#76796 (Give a better error message when x.py uses the wrong stage for CI)
 - rust-lang#76798 (Build fixes for RISC-V 32-bit Linux support)

Failed merges:

r? `@ghost`
@bors bors merged commit 67fa7b7 into rust-lang:master Sep 19, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 19, 2020
@pickfire pickfire deleted the patch-5 branch September 20, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pickfire @rust-highfive @dtolnay @bors @RalfJung @rustbot