UI to unit test for those using Cell/RefCell/UnsafeCell #76454
Conversation
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-testsuite
|
@matklad If you have the time, you can start reviewing this right now. I'm doing a commit per deletion of a file + add its tests into the relevant file inside I can mark commits that address comments with If necessary, I'll squash when this is done (the PR as a whole). |
poliorcetics
changed the title
|
I think I am done with the tests using |
|
☔ The latest upstream changes (presumably #77004) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
poliorcetics
force-pushed
the
ui-to-unit-test-1
branch
from
0732e76
to
5be843f
Compare
| } | ||
|
|
||
| assert_eq!(x.get(), 0); | ||
| } |
There was a problem hiding this comment.
This test feels like it intends to stresses auto-generated drop impl, rather than any specific impl details of standard library, so I think it's OK to keep as an UI test. The best way to check if this intends to check compiler or stdlib is to look at the PR which introduced the test: e47d2f6#diff-518b4158ed084dab26591f1ec09dffef. In this case, this is a change to the compiler.
But keeping this as a #[test] sounds fine by me as well!
There was a problem hiding this comment.
I don't have strong feelings, I just felt it was simple enough to move. I can move it back if necessary.
|
Except for the discussion about |
|
@bors r+ rollup Thanks! |
|
📌 Commit a61b963 has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
…atklad UI to unit test for those using Cell/RefCell/UnsafeCell Helps with rust-lang#76268. I'm working on all files using `Cell` and moving them to unit tests when possible. r? @matklad
…atklad UI to unit test for those using Cell/RefCell/UnsafeCell Helps with rust-lang#76268. I'm working on all files using `Cell` and moving them to unit tests when possible. r? @matklad
Rollup of 7 pull requests Successful merges: - rust-lang#76454 (UI to unit test for those using Cell/RefCell/UnsafeCell) - rust-lang#76474 (Add option to pass a custom codegen backend from a driver) - rust-lang#76711 (diag: improve closure/generic parameter mismatch) - rust-lang#77170 (Remove `#[rustc_allow_const_fn_ptr]` and add `#![feature(const_fn_fn_ptr_basics)]`) - rust-lang#77194 (Add doc alias for iterator fold) - rust-lang#77288 (fix building libstd for Miri on macOS) - rust-lang#77295 (Update unstable-book: Fix ABNF in inline assembly docs) Failed merges: r? `@ghost`
Helps with #76268.
I'm working on all files using
Celland moving them to unit tests when possible.r? @matklad