Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI to unit test for those using Cell/RefCell/UnsafeCell #76454

Merged
merged 14 commits into from
Sep 28, 2020
+667 −687
Merged

UI to unit test for those using Cell/RefCell/UnsafeCell #76454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8aae1ee
Move cell exterior test into library unit tests
poliorcetics Sep 7, 2020
f69c5aa
Move more tests using Cell to unit tests
poliorcetics Sep 7, 2020
af44a2a
move 'cell does not clone' test
poliorcetics Sep 8, 2020
fc152cd
move 'test zip ...' tests
poliorcetics Sep 8, 2020
85b2d9b
fmt
poliorcetics Sep 8, 2020
949c966
move format! interface tests
poliorcetics Sep 8, 2020
ed52c7b
Move deref-lval test
poliorcetics Sep 8, 2020
ac39deb
Move panic safety traits tests
poliorcetics Sep 10, 2020
8904921
Move array cycle test
poliorcetics Sep 10, 2020
275eed7
Move vec-slice-drop test
poliorcetics Sep 10, 2020
6bc0357
Move vec-cycle test
poliorcetics Sep 10, 2020
f6a4189
Move vec-cycle-wrapped test
poliorcetics Sep 11, 2020
5be843f
Move format-ref-cell test
poliorcetics Sep 13, 2020
a61b963
review: fix nits and move panic safety tests to the correct place
poliorcetics Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions library/core/tests/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ mod nonzero;
mod num;
mod ops;
mod option;
mod panic_safe;
poliorcetics marked this conversation as resolved.
Show resolved Hide resolved
mod pattern;
mod ptr;
mod result;
Expand Down
19 changes: 12 additions & 7 deletions src/test/ui/panics/panic-safe.rs → library/core/tests/panic_safe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
// run-pass
#![allow(dead_code)]

use std::panic::{UnwindSafe, AssertUnwindSafe};
use std::cell::RefCell;
use std::sync::{Mutex, RwLock, Arc};
use std::panic::{AssertUnwindSafe, UnwindSafe};
use std::rc::Rc;
use std::sync::{Arc, Mutex, RwLock};

struct Foo { a: i32 }
struct Foo {
a: i32,
}

fn assert<T: UnwindSafe + ?Sized>() {}

fn main() {
#[test]
fn test_panic_safety_traits() {
assert::<i32>();
assert::<&i32>();
assert::<*mut i32>();
Expand All @@ -32,13 +34,16 @@ fn main() {
assert::<Arc<i32>>();
assert::<Box<[u8]>>();

trait Trait: UnwindSafe {}
assert::<Box<dyn Trait>>();
{
trait Trait: UnwindSafe {}
assert::<Box<dyn Trait>>();
}

fn bar<T>() {
assert::<Mutex<T>>();
assert::<RwLock<T>>();
}

fn baz<T: UnwindSafe>() {
assert::<Box<T>>();
assert::<Vec<T>>();
Expand Down