Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars since they are no longer supported by llvm #76472

Merged
merged 1 commit into from
Sep 10, 2020
Merged

rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars since they are no longer supported by llvm #76472

merged 1 commit into from
Sep 10, 2020

Conversation

matthiaskrgr
Copy link
Member

This resolves

CMake Warning:
Manually-specified variables were not used by the project:

PYTHON_EXECUTABLE
WITH_POLLY

@matthiaskrgr
rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars sinc…
0065e33 
…e they are no longer supported by llvm

CMake Warning:
  Manually-specified variables were not used by the project:

    PYTHON_EXECUTABLE
    WITH_POLLY
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Sep 8, 2020

📌 Commit 0065e33 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2020
@bors
Copy link
Contributor

bors commented Sep 8, 2020

⌛ Testing commit 0065e33 with merge 46e1e75447da878dc5b678ec835c0144fcfc7e0b...

@rust-log-analyzer
Copy link
Collaborator

The job i686-mingw-2 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors
Copy link
Contributor

bors commented Sep 8, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 8, 2020
@matthiaskrgr
Copy link
Member Author

spurious network failure

T14:56:48.1468797Z �[0m�[0m�[1m�[32m  Downloaded�[0m semver v0.9.0
2020-09-08T14:56:48.1574092Z �[0m�[0m�[1m�[32m  Downloaded�[0m tracing-subscriber v0.2.11
2020-09-08T14:56:48.1937434Z �[0m�[0m�[1m�[32m  Downloaded�[0m smallvec v0.6.13
2020-09-08T14:56:48.2043999Z �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/itertools/0.8.2/download`, got 503
2020-09-08T14:56:48.2045897Z �[0m�[0m�[1m�[32m  Downloaded�[0m tracing-tree v0.1.5
2020-09-08T14:56:48.2146432Z �[0m�[0m�[1m�[33mwarning�[0m�[1m:�[0m spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/measureme/0.7.1/download`, got 503
2020-09-08T14:56:48.2149029Z �[0m�[0m�[1m�[32m  Downloaded�[0m unicode-script v0.5.2
2020-09-08T14:56:48.2343641Z �[0m�[0m�[1m�[31merror�[0m�[1m:�[0m failed to download from `https://crates.io/api/v1/crates/itertools/0.8.2/download`
2020-09-08T14:56:48.2343994Z 
2020-09-08T14:56:48.2344157Z Caused by:
2020-09-08T14:56:48.2344363Z   failed to get 200 response from `https://crates.io/api/v1/crates/itertools/0.8.2/download`, got 503
2020-09-08T14:56:48.2416120Z command did not execute successfully: "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage0\\bin\\cargo.exe" "build" "--target" "i686-pc-windows-gnu" "-Zbinary-dep-depinfo" "-j" "8" "--release" "--locked" "--color" "always" "--features" " llvm" "--manifest-path" "D:\\a\\rust\\rust\\compiler/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
2020-09-08T14:56:48.2416465Z expected success, got: exit code:

@Xanewok
Copy link
Member

Xanewok commented Sep 9, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Sep 10, 2020
@tmandry
Rollup merge of rust-lang#76472 - matthiaskrgr:llvm_cmake_vars, r=Mar…
eaaac83 
…k-Simulacrum

rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars since they are no longer supported by llvm

This resolves

CMake Warning:
  Manually-specified variables were not used by the project:

    PYTHON_EXECUTABLE
    WITH_POLLY
@tmandry tmandry mentioned this pull request Sep 10, 2020
Closed
@tmandry tmandry mentioned this pull request Sep 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 10, 2020
@bors
Auto merge of rust-lang#76558 - tmandry:rollup-bskim2r, r=tmandry
a1894e4 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#74787 (Move `rustllvm` into `compiler/rustc_llvm`)
 - rust-lang#76458 (Add drain_filter method to HashMap and HashSet)
 - rust-lang#76472 (rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars since they are no longer supported by llvm)
 - rust-lang#76497 (Use intra-doc links in `core::ptr`)
 - rust-lang#76500 (Add -Zgraphviz_dark_mode and monospace font fix)
 - rust-lang#76543 (Document btree's unwrap_unchecked)
 - rust-lang#76556 (Revert rust-lang#76285)

Failed merges:

r? `@ghost`
@bors bors merged commit 9fa0794 into rust-lang:master Sep 10, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
8 participants
@matthiaskrgr @rust-highfive @Mark-Simulacrum @bors @rust-log-analyzer @Xanewok @nikomatsakis @rustbot