Update std::os module documentation.
#76583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! @bors r+ rollup |
|
📌 Commit 7606966c2a80639cf951828b80b4ed504d54c32e has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
the
A-docs
tesuji
reviewed
Sep 11, 2020
library/std/src/os/linux/fs.rs
Outdated
Comment on lines
1
to
2
| #![stable(feature = "metadata_ext", since = "1.1.0")] | ||
|
|
||
| //! Linux-specific extensions to primitives in the `std::fs` module. | ||
|
|
There was a problem hiding this comment.
I prefer moving doc upper the stable attr.
There was a problem hiding this comment.
Ah I see, that's better for consistency. I moved it up, as well as for sys/unix/ext/net.rs
Adds missing descriptions for the modules std::os::linux::fs and std::os::windows::io. Also adds punctuation for consistency with other descriptions.
|
@bors r+ |
|
📌 Commit 954361a has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#76114 (Add saturating methods for `Duration`) - rust-lang#76297 (rustdoc: fix min_const_generics with ty::Param) - rust-lang#76484 (Add MaybeUninit::assume_init_drop.) - rust-lang#76530 (Eliminate mut reference UB in Drop impl for Rc<T>) - rust-lang#76583 (Update `std::os` module documentation.) - rust-lang#76599 (Finish off revisions for const generics UI tests.) - rust-lang#76615 (Add missing examples on binary core traits) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing descriptions for the modules
std::os::linux::fsandstd::os::windows::io.Also adds punctuation for consistency with other descriptions.