Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish off revisions for const generics UI tests. #76599

Merged
merged 2 commits into from Sep 12, 2020
Merged

Finish off revisions for const generics UI tests. #76599

merged 2 commits into from Sep 12, 2020

Conversation

hameerabbasi
Copy link
Contributor

@hameerabbasi hameerabbasi commented Sep 11, 2020 •
edited

This time it really does fix it. 馃槄 The only ones left are min-and-full-same-time.rs, which doesn't need it, and array-impls/ which check the feature indirectly.

Fixes #75279.

r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2020
@lcnr
Copy link
Contributor

lcnr commented Sep 11, 2020

Thanks 馃槅

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 11, 2020

馃搶 Commit 5e188f5 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2020
@RalfJung RalfJung mentioned this pull request Sep 12, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2020
@bors
Auto merge of rust-lang#76637 - RalfJung:rollup-eaykf93, r=RalfJung
2d6cbd2 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#76114 (Add saturating methods for `Duration`)
 - rust-lang#76297 (rustdoc: fix min_const_generics with ty::Param)
 - rust-lang#76484 (Add MaybeUninit::assume_init_drop.)
 - rust-lang#76530 (Eliminate mut reference UB in Drop impl for Rc<T>)
 - rust-lang#76583 (Update `std::os` module documentation.)
 - rust-lang#76599 (Finish off revisions for const generics UI tests.)
 - rust-lang#76615 (Add missing examples on binary core traits)

Failed merges:

r? `@ghost`
@bors bors merged commit 90c5b8f into rust-lang:master Sep 12, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 12, 2020
@lcnr lcnr mentioned this pull request Nov 17, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Use revisions to test min_const_generics
5 participants
@hameerabbasi @lcnr @bors @rust-highfive @rustbot