Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stabilize const_int_pow #76829

Merged
merged 2 commits into from
Nov 23, 2020
Merged

stabilize const_int_pow #76829

merged 2 commits into from
Nov 23, 2020

Conversation

tspiteri
Copy link
Contributor

This also requires stabilizing constctlz for const ctlz_nonzero.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020
@jonas-schievink jonas-schievink added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 17, 2020
@tspiteri
Copy link
Contributor Author

This PR stabilized const for the following public methods:

  • {i*,u*}::checked_pow
  • {i*,u*}::saturating_pow
  • {i*,u*}::wrapping_pow
  • {i*,u*}::overflowing_pow
  • {i*,u*}::pow
  • u*::next_power_of_two
  • u*::checked_next_power_of_two
  • u*::wrapping_next_power_of_two (the method itself is still unstable)

@Mark-Simulacrum
Copy link
Member

r? @KodrAus to kick off libs FCP here, diff in PR looks good from an impl perspective

@bors
Copy link
Contributor

bors commented Sep 19, 2020

☔ The latest upstream changes (presumably #76327) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@bors
Copy link
Contributor

bors commented Sep 23, 2020

☔ The latest upstream changes (presumably #76850) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@tspiteri
Copy link
Contributor Author

tspiteri commented Oct 2, 2020

I've just force-pushed an update with the since field set to "1.49.0" since this cannot possibly complete FCP before 1.48.0 goes into beta.

@KodrAus
Copy link
Contributor

KodrAus commented Oct 5, 2020

@rfcbot fcp merge

See: #76829 (comment)

This stabilizes a few more const methods on integers.

cc @rust-lang/wg-const-eval

@rfcbot
Copy link

rfcbot commented Oct 5, 2020 •
edited by BurntSushi
Loading

Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 5, 2020
@crlf0710 crlf0710 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 13, 2020
@rfcbot
Copy link

rfcbot commented Nov 13, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@bors
Copy link
Contributor

bors commented Nov 18, 2020

☔ The latest upstream changes (presumably #79167) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 23, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 23, 2020

@bors r-

yea, please adjust the stabilization date, too

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 23, 2020
@tspiteri
Copy link
Contributor Author

Done.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 23, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 23, 2020

📌 Commit a6bcf7a has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2020
@bors
Copy link
Contributor

bors commented Nov 23, 2020

⌛ Testing commit a6bcf7a with merge b1801ff6fe6c747687a9e423da6fda1d0c736835...

@bors
Copy link
Contributor

bors commented Nov 23, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 23, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 23, 2020

@bors retry gzip failures in CI

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2020
@jonas-schievink jonas-schievink mentioned this pull request Nov 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2020
@bors
Auto merge of rust-lang#79345 - jonas-schievink:rollup-1yhhzx9, r=jon…
40624dd 
…as-schievink

Rollup of 10 pull requests

Successful merges:

 - rust-lang#76829 (stabilize const_int_pow)
 - rust-lang#79080 (MIR visitor: Don't treat debuginfo field access as a use of the struct)
 - rust-lang#79236 (const_generics: assert resolve hack causes an error)
 - rust-lang#79287 (Allow using generic trait methods in `const fn`)
 - rust-lang#79324 (Use Option::and_then instead of open-coding it)
 - rust-lang#79325 (Reduce boilerplate with the `?` operator)
 - rust-lang#79330 (Fix typo in comment)
 - rust-lang#79333 (doc typo)
 - rust-lang#79337 (Use Option::map instead of open coding it)
 - rust-lang#79343 (Add my (`@flip1995)` work mail to the mailmap)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 703f176 into rust-lang:master Nov 23, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 23, 2020
@tspiteri tspiteri deleted the const-int-pow branch November 23, 2020 21:30
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Dec 3, 2020
vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 9, 2020
Remove const_int_pow feature flag
7d9128c 
const_int_pow was stabilized in Rust 1.50.0
rust-lang/rust#76829
@vlvrd vlvrd mentioned this pull request Dec 9, 2020
Merged
vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 11, 2020
Remove const_int_pow feature flag
51d1caa 
const_int_pow was stabilized in Rust 1.50.0
rust-lang/rust#76829
vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 14, 2020
Remove const_int_pow feature flag
a2c3c00 
const_int_pow was stabilized in Rust 1.50.0
rust-lang/rust#76829
vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 15, 2020
Remove const_int_pow feature flag
e187c80 
const_int_pow was stabilized in Rust 1.50.0
rust-lang/rust#76829
jgraef pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 17, 2020
@jgraef
Remove const_int_pow feature flag
53f787b 
const_int_pow was stabilized in Rust 1.50.0
rust-lang/rust#76829
jgraef pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 17, 2020
@jgraef
Remove const_int_pow feature flag
342e5cf 
const_int_pow was stabilized in Rust 1.50.0
rust-lang/rust#76829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

@dtolnay dtolnay dtolnay approved these changes

Assignees

@KodrAus KodrAus

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

None yet