Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for issue #76042 #77151

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Add regression test for issue #76042 #77151

merged 1 commit into from
Nov 13, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Originally posted in #76042 (comment).
r? @pnkfelix

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2020
@RalfJung
Copy link
Member

(FWIW, I'd appreciate if you could create such branches in forks, not the main repo... it is somewhat confusing to have these things how up in my git branch -r or when navigating the main Rust repo.^^)

@LeSeulArtichaut
Copy link
Contributor Author

Oops, sorry, I didn’t even notice. I just used GitHub UI to create the commit and forgot I had write access :)

@camelid camelid added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 16, 2020
@pnkfelix
Copy link
Member

r=me once the test is actually updated in the manner described in #77151 (comment)

@pnkfelix pnkfelix added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2020
@LeSeulArtichaut
Copy link
Contributor Author

@pnkfelix Updated the test

@LeSeulArtichaut LeSeulArtichaut added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2020
@pnkfelix
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 13, 2020

📌 Commit e8bda8d has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2020
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2020
@bors
Auto merge of rust-lang#79017 - GuillaumeGomez:rollup-5orhudd, r=Guil…
f2a11a2 
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#77151 (Add regression test for issue rust-lang#76042)
 - rust-lang#77996 (Doc change: Remove mention of `fnv` in HashMap)
 - rust-lang#78463 (Add type to `ConstKind::Placeholder`)
 - rust-lang#78984 (Rustdoc check option)
 - rust-lang#78985 (add dropck test for const params)
 - rust-lang#78996 (add explicit test for const param promotion)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c5a11dd into master Nov 13, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 13, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the LeSeulArtichaut-patch-1 branch November 13, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmiasko tmiasko tmiasko left review comments

Assignees

@pnkfelix pnkfelix

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@LeSeulArtichaut @RalfJung @pnkfelix @bors @tmiasko @rust-highfive @camelid @rustbot