Add type to ConstKind::Placeholder
#78463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
varkor
added
the
A-const-generics
varkor
force-pushed
the
placeholder-const
branch
from
e7fd4fe
to
eb40907
Compare
varkor
commented
Oct 28, 2020
lcnr
reviewed
Oct 28, 2020
varkor
force-pushed
the
placeholder-const
branch
from
eb40907
to
8014f1e
Compare
nikomatsakis
reviewed
Nov 9, 2020
varkor
force-pushed
the
placeholder-const
branch
from
8014f1e
to
ba4bb90
Compare
nikomatsakis
requested changes
Nov 12, 2020
varkor
force-pushed
the
placeholder-const
branch
from
ba4bb90
to
e24a4b4
Compare
|
@bors r+ |
|
📌 Commit e24a4b4 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2020
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#77151 (Add regression test for issue rust-lang#76042) - rust-lang#77996 (Doc change: Remove mention of `fnv` in HashMap) - rust-lang#78463 (Add type to `ConstKind::Placeholder`) - rust-lang#78984 (Rustdoc check option) - rust-lang#78985 (add dropck test for const params) - rust-lang#78996 (add explicit test for const param promotion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simply threaded
<'tcx>through everything that required it. I'm not sure whether this is the correct thing to do, but it seems to work.r? @nikomatsakis