Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings in preparation for const value trees #77227

Merged
merged 26 commits into from
Nov 4, 2020
Merged

Refactorings in preparation for const value trees #77227

merged 26 commits into from
Nov 4, 2020

Commits on Nov 4, 2020

  1. Split the "raw integer bytes" part out of Scalar

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    362123d View commit details
    Browse the repository at this point in the history

  2. Encode ScalarInt::bytes as u128 instead of [u8; 16] to see if t… 

    …hat caused the performance regression
    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    eac3099 View commit details
    Browse the repository at this point in the history

  3. 32 bit platforms don't have 64 bit pointers

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    ed7a4ad View commit details
    Browse the repository at this point in the history

  4. Use packed struct instead of manually packing into an array

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    02131f4 View commit details
    Browse the repository at this point in the history

  5. Explain the use of blocks around self.data accesses

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    c478574 View commit details
    Browse the repository at this point in the history

  6. Fix cranelift build

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    3a79708 View commit details
    Browse the repository at this point in the history

  7. s/Scalar::Raw/Scalar::Int

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    df4d717 View commit details
    Browse the repository at this point in the history

  8. Remove outdated FIXME

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    e5258e6 View commit details
    Browse the repository at this point in the history

  9. Unaligned reads are UB in Rust irrelevant on which platform we are

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    1eb300e View commit details
    Browse the repository at this point in the history

  10. Update comment

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    3ef9dfd View commit details
    Browse the repository at this point in the history

  11. No need for a zst constructor method when we can have a constant

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    b8751c1 View commit details
    Browse the repository at this point in the history

  12. Replace Scalar::zst with a Scalar::ZST constant

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    8282d52 View commit details
    Browse the repository at this point in the history

  13. catch conversion errors during ptr_sized_op

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    d1074ed View commit details
    Browse the repository at this point in the history

  14. Explain why we forward to self-printing during self-printing

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    0347ca7 View commit details
    Browse the repository at this point in the history

  15. Add is_null helper 

    This is cheaper than creating a null-`ScalarInt` and comparing
and then just throwing it away.
    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    f03b18b View commit details
    Browse the repository at this point in the history

  16. Add helper for getting an int out of a Scalar

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    500af76 View commit details
    Browse the repository at this point in the history

  17. Do not raise interp errors from the scalar int module

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    dad0036 View commit details
    Browse the repository at this point in the history

  18. Simplify assert_bits impl

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    98b70c9 View commit details
    Browse the repository at this point in the history

  19. Update compiler/rustc_middle/src/ty/consts/int.rs 

    Co-authored-by: Ralf Jung <post@ralfj.de>
    @oli-obk @RalfJung
    oli-obk and RalfJung committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    cb1cf6a View commit details
    Browse the repository at this point in the history

  20. Move ZST constant to the top of the impl block

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    e67c768 View commit details
    Browse the repository at this point in the history

  21. u128 truncation and sign extension are not just interpreter related

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    abacaf2 View commit details
    Browse the repository at this point in the history

  22. Document an unwrap

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    2e53625 View commit details
    Browse the repository at this point in the history

  23. Make ScalarInt entirely independent of MIR interpretation

    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    97bfff1 View commit details
    Browse the repository at this point in the history

  24. u64::try_from will now fail if ScalarInt isn't exactly 64 bits, t… 

    …hus we use `to_bits` with the correct size
    @oli-obk
    oli-obk committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    6e6c8a8 View commit details
    Browse the repository at this point in the history

  25. Update compiler/rustc_target/src/abi/mod.rs 

    Co-authored-by: Ralf Jung <post@ralfj.de>
    @oli-obk @RalfJung
    oli-obk and RalfJung committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    5f087f0 View commit details
    Browse the repository at this point in the history

  26. Update compiler/rustc_target/src/abi/mod.rs 

    Co-authored-by: Ralf Jung <post@ralfj.de>
    @oli-obk @RalfJung
    oli-obk and RalfJung committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    332750f View commit details
    Browse the repository at this point in the history