Disable the SimplifyArmIdentity mir-opt #77396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Oct 1, 2020
...test/mir-opt/simplify_locals_removes_unused_discriminant_reads.map.SimplifyLocals.64bit.diff
Show resolved
Hide resolved
|
r=me with 32 bit files updated |
wesleywiser
force-pushed
the
disable-simplifyarmidentity
branch
2 times, most recently
from
13fe848
to
52a248c
Compare
The optimization still has some bugs that need to be worked out such as rust-lang#77359. We can try re-enabling this again after the known issues are resolved.
wesleywiser
force-pushed
the
disable-simplifyarmidentity
branch
from
52a248c
to
f9d7720
Compare
|
@bors r=oli-obk rollup=never p=5 Closes an unsound nightly regression. |
|
📌 Commit f9d7720 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit f9d7720 with merge 9cec822f5e3bf56415f98113bf85a1d0904d897e... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization still has some bugs that need to be worked out
such as #77359.
We can try re-enabling this again after the known issues are resolved.
r? @oli-obk