Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add advance_by and advance_back_by" #77601

Closed
wants to merge 1 commit into from

Conversation

ecstatic-morse
Copy link
Contributor

@ecstatic-morse ecstatic-morse commented Oct 6, 2020

r? @ghost

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2020
@ecstatic-morse
Copy link
Contributor Author

@bors try
@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Oct 6, 2020

⌛ Trying commit e16d17a with merge 66905b979037ebdafdb00186e8d15dc1f358750d...

@bors
Copy link
Contributor

bors commented Oct 6, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 66905b979037ebdafdb00186e8d15dc1f358750d (66905b979037ebdafdb00186e8d15dc1f358750d)

@rust-timer
Copy link
Collaborator

Queued 66905b979037ebdafdb00186e8d15dc1f358750d with parent a1dfd24, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (66905b979037ebdafdb00186e8d15dc1f358750d): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants