Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure rustc_driver links to an unwinder #77815

Closed
wants to merge 1 commit into from
Closed

make sure rustc_driver links to an unwinder #77815

wants to merge 1 commit into from

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Oct 11, 2020

Fixes #76020

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2020
@Keruspe Keruspe mentioned this pull request Oct 11, 2020
Merged
@varkor
Copy link
Member

varkor commented Oct 11, 2020

I don't see a problem with this, but I'd prefer someone else to take a look.

r? @Mark-Simulacrum

@Keruspe
Copy link
Contributor Author

Keruspe commented Oct 11, 2020

I'll give the CI failure a look later today

@camelid camelid added the A-driver Area: rustc_driver that ties everything together into the `rustc` compiler label Oct 12, 2020
@Keruspe
make sure rustc_driver links to an unwinder
8645659 
Fixes rust-lang#76020

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@Keruspe
Copy link
Contributor Author

Keruspe commented Oct 12, 2020

Now both ./x.py check and ./x.py build should pass

@Mark-Simulacrum
Copy link
Member

It sounds like this is the wrong fix (#76020 (comment)), could you respond to that? @petrhosek seems to suggest a different change as well.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020
@Keruspe
Copy link
Contributor Author

Keruspe commented Oct 13, 2020

I guess, yup. Let's close this, I have no clue as to how to fix this properly with the in-tree libunwind

@Keruspe Keruspe closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.46.0 fails to build with llvm-libunwind enabled
5 participants
@Keruspe @rust-highfive @varkor @Mark-Simulacrum @camelid