Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #78060

Merged
merged 15 commits into from
Oct 17, 2020
Merged

Rollup of 7 pull requests #78060

merged 15 commits into from
Oct 17, 2020

Commits on Sep 15, 2020

  1. Modify executable checking to be more universal

    This uses a dummy file to check if the filesystem being used supports the
    executable bit in general.
    Mark-Simulacrum committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    05c9c0e View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. BTreeMap: refactor Entry out of map.rs into its own file

    btree/map.rs is approaching the 3000 line mark, splitting out the entry
    code buys about 500 lines of headroom
    Jacob Hughes committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    4b96049 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. Configuration menu
    Copy the full SHA
    786e3ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3522add View commit details
    Browse the repository at this point in the history
  3. Suggest correct place to add self parameter when inside closure

    It would incorrectly suggest adding it as a parameter to the closure instead of the
    containing function.
    blyxxyz committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    e701ae3 View commit details
    Browse the repository at this point in the history
  4. Small CSS cleanup

    GuillaumeGomez committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    3566132 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    28f350e View commit details
    Browse the repository at this point in the history
  6. Appease the almightly lord clippy, hallowed be thy name

    Jacob Hughes committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    3e2121c View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#75802 - petrochenkov:nometa, r=nikomatsakis

    resolve: Do not put nonexistent crate `meta` into prelude
    
    Before the 2018 edition release there was some vague suggestion about adding a crate named `meta` to the standard distribution.
    On this basis the name `meta` was "partially reserved" by putting `meta` into extern prelude (this means importing something named `meta` will result in an ambiguity error, for example).
    This only caused confusion so far, and two years later there are no specific plans to add such crate.
    
    If some standard crate (named `meta` or not) is added in the future, then cargo will hopefully already have ability to put it into extern prelude explicitly through `Cargo.toml`.
    Otherwise, it could be added to extern prelude by the compiler at edition boundary.
    
    Closes rust-lang#73948
    JohnTitor committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    d10b98d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#76607 - Mark-Simulacrum:tidy-bins, r=pnkfelix

    Modify executable checking to be more universal
    
    This uses a dummy file to check if the filesystem being used supports the executable bit in general.
    
    Supersedes rust-lang#74753.
    JohnTitor committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    83ee319 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#77851 - exrook:split-btreemap, r=dtolnay

    BTreeMap: refactor Entry out of map.rs into its own file
    
    btree/map.rs is approaching the 3000 line mark, splitting out the entry
    code buys about 500 lines of headroom.
    
    I've created this PR because the changes I've made in rust-lang#77438 will push `map.rs` over the 3000 line limit and cause tidy to complain.
    
    I picked `Entry` to factor out because it feels less tightly coupled to the rest of `BTreeMap` than the various iterator implementations.
    
    Related: rust-lang#60302
    JohnTitor committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    a0242e7 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#78043 - willcrozi:e0210-error-note-fix, r=lcnr

    Fix grammar in note for orphan-rule error [E0210]
    
    Fixes the grammar in the error note for [E0210] from:
    
    _"= note: implementing a foreign trait is only possible if at least one of the types for which **is it** implemented is local"_
    
    to:
    
    _"= note: implementing a foreign trait is only possible if at least one of the types for which **it is** implemented is local"_
    
    The content of this commit is the result of running the following command at the repository root:
    
    `find . \( -type d -name .git -prune \) -o -type f -print0 | xargs -0 sed -i 's/which is it implemented/which it is implemented/g'`
    JohnTitor committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    407bba4 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#78048 - blyxxyz:e0424-improve-self-placemen…

    …t, r=lcnr
    
    Suggest correct place to add `self` parameter when inside closure
    
    It would incorrectly suggest adding it as a parameter to the closure instead of the containing function.
    
    [For example](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=1936bcd1e5f981573386e0cee985c3c0):
    ```
    help: add a `self` receiver parameter to make the associated `fn` a method
      |
    5 |         let _ = || self&self;
      |                        ^^^^^
    ```
    
    `DiagnosticMetadata.current_function` is only used for these messages so tweaking its behavior should be ok.
    JohnTitor committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    57e38dd View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#78050 - GuillaumeGomez:small-css-cleanup, r…

    …=jyn514
    
    Small CSS cleanup
    
    r? @jyn514
    JohnTitor committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    ed79320 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#78059 - JohnTitor:fix-linkcheck, r=ehuss

    Set `MDBOOK_OUTPUT__HTML__INPUT_404` on linkchecker
    
    This is found in rust-lang/nomicon#240.
    It seems the spurious failure shows up without this flag.
    JohnTitor committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    ffed6af View commit details
    Browse the repository at this point in the history