Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable "optimization to avoid load of address" in InstCombine #78434

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Disable "optimization to avoid load of address" in InstCombine #78434

merged 1 commit into from
Oct 27, 2020

Conversation

jonas-schievink
Copy link
Contributor

Same as #78195, fixes #78192 (again).

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 27, 2020
Closed
@wesleywiser
Copy link
Member

r? @wesleywiser
@bors r+ p=5

Soundness fix

@bors
Copy link
Contributor

bors commented Oct 27, 2020

📌 Commit 0be35cf has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2020
@wesleywiser wesleywiser added the A-mir-opt Area: MIR optimizations label Oct 27, 2020
@bors
Copy link
Contributor

bors commented Oct 27, 2020

⌛ Testing commit 0be35cf with merge 2a71e45...

@jonas-schievink jonas-schievink added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 27, 2020
@wesleywiser
Copy link
Member

Since #78195 was beta-nominated and accepted, this doesn't need to be beta-nominated right?

@bors
Copy link
Contributor

bors commented Oct 27, 2020

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 2a71e45 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2020
@bors bors merged commit 2a71e45 into rust-lang:master Oct 27, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 27, 2020
@jonas-schievink jonas-schievink deleted the disable-miropt branch October 27, 2020 18:42
@jonas-schievink
Copy link
Contributor Author

@wesleywiser Ah, right, that just hasn't been backported yet

@jonas-schievink jonas-schievink removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
A-mir-opt Area: MIR optimizations merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

InstCombine introduces an incorrect use of a local after its storage has ended
6 participants
@jonas-schievink @rust-highfive @wesleywiser @bors @matthewjasper @rustbot