Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const generics tests for supertraits + dyn traits. #78478

Merged
merged 3 commits into from Oct 29, 2020

Conversation

hameerabbasi
Copy link
Contributor

Partially addresses #78433

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2020
@hameerabbasi
Copy link
Contributor Author

r? @lcnr

@varkor varkor added A-const-generics Area: const generics (parameters and arguments) F-min_const_generics labels Oct 28, 2020
@hameerabbasi hameerabbasi added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 28, 2020
@lcnr
Copy link
Contributor

lcnr commented Oct 28, 2020

This is already looking good, a few more cases to consider might be:

fn generic<T: Bok<N>, const N: usize>(v: T) {
    fn_taking_taking_dyn_foo::<N>(&v);
}

fn concrete<T: ?Sized + Foo<3>>(_: &T) {}
fn call_super_concrete(x: &dyn Bar<3>) {
    concrete(x);
}

Also, it would be great to change this test to // run-pass and add some simple methods to the trait and super traits and calls those too in dynamic contexts.

@lcnr
Copy link
Contributor

lcnr commented Oct 28, 2020

👍

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 28, 2020

📌 Commit 22060fa has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#77213 (rustdoc options to set default theme (and other settings))
 - rust-lang#78224 (min_const_generics: allow ty param in repeat expr)
 - rust-lang#78428 (MinConstGenerics UI test for invalid values for bool & char)
 - rust-lang#78460 (Adjust turbofish help message for const generics)
 - rust-lang#78470 (Clean up intra-doc links in `std::path`)
 - rust-lang#78475 (fix a comment in validity check)
 - rust-lang#78478 (Add const generics tests for supertraits + dyn traits.)
 - rust-lang#78487 (Fix typo "compiltest")
 - rust-lang#78491 (Inline NonZeroN::from(n))
 - rust-lang#78492 (Update books)
 - rust-lang#78494 (Fix typos)

Failed merges:

r? `@ghost`
@bors bors merged commit 572ea25 into rust-lang:master Oct 29, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 29, 2020
@hameerabbasi hameerabbasi deleted the const-generics-supertraits branch October 29, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-generics Area: const generics (parameters and arguments) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants