Bump Rustfmt and RLS

[ghedo]

Should hopefully fix #78341 and fix #78340.

[rust-highfive]

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify submodules.

[calebcartwright]

@Mark-Simulacrum - besides addressing the broken toolstate, the rustfmt update also include the bump of the rustc-ap-* crates that contain the changes from #77774 which fixed a panic on the rustfmt side.

I believe #77774 was, ostensibly, backported due to wanting to address that panic issue, so i'm not sure if there's a desire to do something similar here. Probably worth noting we've had a flood of duplicative reports about the same panic issue over in rustfmt.

[Xanewok]

CI says that RLS tests fail but I can't reproduce locally. However, I'm getting a Rustfmt compilation error:

error: this `#[deprecated]` annotation has no effect
   --> src/tools/rustfmt/src/lib.rs:276:1
    |
276 | #[deprecated(note = "Use FormatReportFormatter instead")]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the unnecessary deprecation attribute
    |
    = note: `#[deny(useless_deprecated)]` on by default

[calebcartwright]

Wonder if this comes from #78626, as there weren't any related changes on the rustfmt side that would've introduced this

[calebcartwright]

@Xanewok - I'm going to have to cut a new release to address this, so another PR to RLS will be on it's way to you shortly

[calebcartwright]

@ghedo - would you be willing to update the submods here to pull in the latest changes?

rustfmt should now be on the rustfmt-1.4.24 branch on commit rust-lang/rustfmt@eb894d5 and rls now up to rust-lang/rls@dab1468

[ghedo]

Sure, done. Let's see how it goes 🤞

[Xanewok]

Last hurdle:

the following dependencies are duplicated although they have the same features enabled:
the following dependencies have different features:
  byteorder 1.3.4 (registry+https://github.com/rust-lang/crates.io-index)
    `rustfmt` additionally enabled features {} at "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libbyteorder-c5e2ae63a4128905.rlib"
    `rls` additionally enabled features {"default", "std"} at "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libbyteorder-286667693f43f34e.rlib"

to fix this you will probably want to edit the local src/tools/rustc-workspace-hack/Cargo.toml crate, as that will update the dependency graph to ensure that these crates all share the same feature set

[rust-log-analyzer]

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
[command]/usr/bin/git config --local http.https://github.com/.extraheader AUTHORIZATION: basic ***
##[endgroup]
##[group]Fetching the repository
[command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=2 origin +74e951434536a7980ce81a4e4f8ebfcb127bfbe5:refs/remotes/pull/78775/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

[Mark-Simulacrum]

beta-nominating per #78775 (comment)

@bors r+

[bors]

📌 Commit bff2e46 has been approved by Mark-Simulacrum

[Aaron1011]

This fixes the toolstate.

@bors p=1

[bors]

⌛ Testing commit bff2e46 with merge 07684add9321e1f9a1381dee89bb86b3fb689171...

[bors]

💔 Test failed - checks-actions

[Aaron1011]

Spurious failure: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/apple-x86_64.20gha.20checks

@bors retry

[bors]

⌛ Testing commit bff2e46 with merge b1277d0...