Revert "Revert "resolve: Avoid "self-confirming" import resolutions in one more case"" #78784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
added
the
beta-nominated
|
beta-nominating since this targets a fix to a beta regression, #77586. |
jyn514
added
A-resolve
|
It would be nice to keep the test, but otherwise r=me. |
petrochenkov
added
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
revert-77421
branch
from
36541cf
to
41ff118
Compare
petrochenkov
reviewed
Nov 6, 2020
…n one more case"" This reverts commit b20bce8. It retains the test added in that commit as a check-pass test, intended to prevent future (unintentional) regressions.
Mark-Simulacrum
force-pushed
the
revert-77421
branch
from
41ff118
to
ae4f80b
Compare
|
@bors r=petrochenkov |
|
📌 Commit ae4f80b has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 because of beta-nom (we're T-2 weeks from release day) |
|
☀️ Test successful - checks-actions |
rustbot
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2020
…ulacrum [beta] next This backports: * Avoid installing external LLVM dylibs rust-lang#78986 * Install CI llvm into the library directory rust-lang#79074 * Revert "Revert "resolve: Avoid "self-confirming" import resolutions in one more case"" rust-lang#78784 * Bump Rustfmt and RLS rust-lang#78775 * Enforce no-move rule of ReentrantMutex using Pin and fix UB in stdio rust-lang#77801 For RLS/rustfmt compilation to succeed: * change the order of type arguments on ControlFlow rust-lang#76614 * Add ControlFlow::is_{break,continue} methods rust-lang#78200 * Replace run_compiler with RunCompiler builder pattern rust-lang#77649 As a dependency of rust-lang#77801: * Add Pin::static_ref, static_mut. rust-lang#77726
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this reverts commit b20bce8 from #77421 to fix #77586.
The lang team has decided that for the time being we want to avoid the breakage here (perhaps for a future edition; though almost certainly not the upcoming one), though a future PR may want to add a lint around this case (and perhaps others) which are unlikely to be readable code.
r? @petrochenkov to confirm this is the right way to fix #77586.