Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #79319

Merged
merged 25 commits into from
Nov 23, 2020
Merged

Rollup of 10 pull requests #79319

merged 25 commits into from
Nov 23, 2020

Commits on Nov 6, 2020

  1. Clean up StructuralEq docs

    camelid committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b813c72 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Configuration menu
    Copy the full SHA
    0f005c2 View commit details
    Browse the repository at this point in the history
  2. Split iterator adaptors into individual modules

    This commit also makes fields of `Take` private. I have no idea why they
    were `pub(super)` before.
    WaffleLapkin committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    773b73c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66d6708 View commit details
    Browse the repository at this point in the history
  4. Merge uses in core::iter

    WaffleLapkin committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    b82a76a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0dc187c View commit details
    Browse the repository at this point in the history
  6. Fix UI tests

    Some UI tests started failing after moving iterator adapters to different modules.
    WaffleLapkin committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    e0e906b View commit details
    Browse the repository at this point in the history
  7. Remove multiline uses

    WaffleLapkin committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    4612658 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Add test for eval order for a+=b

    Yes, the order of evaluation *does* change depending on the types of
    the operands. Cursed, I know.
    
    I've elected to place this test into `expr/compound-assignment` creating
    both the `expr` directory and the `compound-assignment` directory. I
    plan in a future PR to also move the `if` directory and the loose `if`
    tests into `expr/if` and other similar cleanups of the `test/ui`
    directory.
    
    Future work: Test more than just `+=`, but all operators. I don't know
    if using a macro to generate these tests cases would be okay or not,
    but it'd be boilerplatey without it. I'm also confident you cannot
    change the evaluation order of one operator without changing all of
    them.
    
    Future work: Additionally, test more than just `i32 += i32` for the
    primitive version. I don't actually know the full set of primitive
    implementations, but I imagine there's enough to cause a combinatorial
    explosion with the previous future work item. Somewhere on the order of
    one to two hundred individual functions.
    Havvy committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    b6f9705 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9186c07 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b04abc4 View commit details
    Browse the repository at this point in the history
  4. Stabilise then

    varkor committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    cf32afc View commit details
    Browse the repository at this point in the history
  5. Stabilize refcell_take

    ThinkChaos committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    5c6689b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cf26f2f View commit details
    Browse the repository at this point in the history
  7. Stabilize alloc::Layout const functions

    Stabilizes rust-lang#67521. In particular the following stable methods are stabilized as const fn:
    
    * size
    * align
    * from_size_align
    ChrisDenton committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    9050d12 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#76941 - clarfonthey:is_subnormal, r=m-ou-se

    Add f{32,64}::is_subnormal
    
    The docs recommend that you use dedicated methods instead of calling `classify` directly, although there isn't actually a way of checking if a number is subnormal without calling classify. There are dedicated methods for all other forms, excluding `is_zero` (which is just `== 0.0` anyway).
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    9b98f1d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#77697 - WaffleLapkin:iter_split_adaptors, r…

    …=m-ou-se
    
    Split each iterator adapter and source into individual modules
    
    This PR creates individual modules for each iterator adapter and iterator source.
    
    This is done to enhance the readability of corresponding modules (`adapters/mod.rs` and `sources.rs`) which were hard to navigate and read because of lots of repeated lines (e.g.: `adapters/mod.rs` was 3k lines long). This is also in line with some adapters which already had their own modules (`Flatten`, `FlatMap`, `Chain`, `Zip`, `Fuse`).
    
    This PR also makes `Take`s adapter fields private (I have no idea why they were `pub(super)` before).
    
    r? ``@LukasKalbertodt``
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    4407049 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#78305 - ChrisDenton:const-layout, r=oli-obk

    Stabilize alloc::Layout const functions
    
    Stabilizes rust-lang#67521. In particular the following stable methods are stabilized as `const fn`:
    
    * `size`
    * `align`
    * `from_size_align`
    
    Stabilizing `size` and `align` should not be controversial as they are simple (usize and NonZeroUsize) fields and I don't think there's any reason to make them not const compatible in the future. That being true, the other methods are trivially `const`. The only other issue being returning a `Result` from a `const fn` but this has been made more usable by recent stabilizations.
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    186ec64 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#78608 - ThinkChaos:stabilize_refcell_take, …

    …r=m-ou-se
    
    Stabilize refcell_take
    
    Tracking Issue: rust-lang#71395
    
    ``@KodrAus`` nominated this for FCP, so here's a PR!
    I've never made a stabilization PR, so please mention if there's anything I can improve, thanks.
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    b249844 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#78793 - camelid:fixup-structuraleq, r=jyn514

    Clean up `StructuralEq` docs
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    8a623e6 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#79267 - ssomers:btree_namespaces, r=Mark-Si…

    …mulacrum
    
    BTreeMap: address namespace conflicts
    
    Fix an annoyance popping up whenever synchronizing the test cases with a version capable of miri-track-raw-pointers.
    
    r? `@Mark-Simulacrum`
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    5793fa9 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#79293 - Havvy:test-eval-order-compound-assi…

    …gn, r=Mark-Simulacrum
    
    Add test for eval order for a+=b
    
    Yes, the order of evaluation *does* change depending on the types of
    the operands. Cursed, I know.
    
    I've elected to place this test into `expr/compound-assignment` creating
    both the `expr` directory and the `compound-assignment` directory. I
    plan in a future PR to also move the `if` directory and the loose `if`
    tests into `expr/if` and other similar cleanups of the `test/ui`
    directory.
    
    Future work: Test more than just `+=`, but all operators. I don't know
    if using a macro to generate these tests cases would be okay or not,
    but it'd be boilerplatey without it. I'm also confident you cannot
    change the evaluation order of one operator without changing all of
    them.
    
    Future work: Additionally, test more than just `i32 += i32` for the
    primitive version. I don't actually know the full set of primitive
    implementations, but I imagine there's enough to cause a combinatorial
    explosion with the previous future work item. Somewhere on the order of
    one to two hundred individual functions.
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    138845d View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#79295 - ssomers:btree_fix_78903, r=Mark-Sim…

    …ulacrum
    
    BTreeMap: fix minor testing mistakes in rust-lang#78903
    
    Mostly a duplicate test case
    r? `@Mark-Simulacrum`
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    b54838f View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#79297 - ssomers:btree_post_redux, r=Mark-Si…

    …mulacrum
    
    BTreeMap: swap the names of NodeRef::new and Root::new_leaf
    
    rust-lang#78104 preserved the name of Root::new_leaf to minimize changes, but the resulting names are confusing.
    
    r? `@Mark-Simulacrum`
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    d39e095 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#79299 - varkor:stabilise-then, r=m-ou-se

    Stabilise `then`
    
    Stabilises the lazy variant of rust-lang#64260 now that the FCP [has ended](rust-lang#64260 (comment)).
    
    I've kept the original feature gate `bool_to_option` for the strict variant (`then_some`), and created a new insta-stable feature gate `lazy_bool_to_option` for `then`.
    m-ou-se committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    41c033b View commit details
    Browse the repository at this point in the history