-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Issue for RefCell::take
#71395
Labels
B-unstable
Blocker: Implemented in the nightly compiler and unstable.
C-tracking-issue
Category: A tracking issue for an RFC or an unstable feature.
Libs-Small
Libs issues that are considered "small" or self-contained
Libs-Tracked
Libs issues that are tracked on the team's project board.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Merged
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
May 3, 2020
…asKalbertodt Add `RefCell::take` Add `RefCell::take` to match `Cell` and `Option`. I also changed a couple of calls to `.replace` to `.take`. Tracking issue is rust-lang#71395. This is my first contribution, please tell me if there's anything I could improve, thanks!
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
May 3, 2020
…asKalbertodt Add `RefCell::take` Add `RefCell::take` to match `Cell` and `Option`. I also changed a couple of calls to `.replace` to `.take`. Tracking issue is rust-lang#71395. This is my first contribution, please tell me if there's anything I could improve, thanks!
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
May 3, 2020
…asKalbertodt Add `RefCell::take` Add `RefCell::take` to match `Cell` and `Option`. I also changed a couple of calls to `.replace` to `.take`. Tracking issue is rust-lang#71395. This is my first contribution, please tell me if there's anything I could improve, thanks!
4 tasks
If anybody would like to open a stabilization PR for this we can kick off a FCP! |
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this issue
Nov 22, 2020
…r=m-ou-se Stabilize refcell_take Tracking Issue: rust-lang#71395 `@KodrAus` nominated this for FCP, so here's a PR! I've never made a stabilization PR, so please mention if there's anything I can improve, thanks.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this issue
Nov 22, 2020
…r=m-ou-se Stabilize refcell_take Tracking Issue: rust-lang#71395 ``@KodrAus`` nominated this for FCP, so here's a PR! I've never made a stabilization PR, so please mention if there's anything I can improve, thanks.
Think this issue should probably be closed, since it's now been stabilized! |
twilco
added a commit
to twilco/accountable-refcell
that referenced
this issue
Dec 11, 2020
This changeset also clarifies the language around mutable borrows. The message accountable_refcell paniced with when trying to take a mutable borrow was not entirely accurate ("RefCell is already immutably borrowed"), as panics can also occur when trying to mutably borrow a RefCell that is already mutably borrowed. Technically, at the time of this writing, the `take` method is not in stable Rust, but will be in the next version (1.49) rust-lang/rust#71395 A rust-toolchain file has been added codifying the expectation that this crate targets stable Rust.
twilco
added a commit
to twilco/accountable-refcell
that referenced
this issue
Dec 11, 2020
This changeset also clarifies the language around mutable borrows. The message accountable_refcell paniced with when trying to take a mutable borrow was not entirely accurate ("RefCell is already immutably borrowed"), as panics can also occur when trying to mutably borrow a RefCell that is already mutably borrowed. Technically, at the time of this writing, the `take` method is not in stable Rust, but will be in the next version (1.49) rust-lang/rust#71395 A rust-toolchain file has been added codifying the expectation that this crate targets stable Rust.
twilco
added a commit
to twilco/accountable-refcell
that referenced
this issue
Dec 11, 2020
This changeset also clarifies the language around mutable borrows. The message accountable_refcell paniced with when trying to take a mutable borrow was not entirely accurate ("RefCell is already immutably borrowed"), as panics can also occur when trying to mutably borrow a RefCell that is already mutably borrowed. Technically, at the time of this writing, the `take` method is not in stable Rust, but will be in the next version (1.49) rust-lang/rust#71395 A rust-toolchain file has been added codifying the expectation that this crate targets stable Rust.
jdm
pushed a commit
to jdm/accountable-refcell
that referenced
this issue
Dec 11, 2020
This changeset also clarifies the language around mutable borrows. The message accountable_refcell paniced with when trying to take a mutable borrow was not entirely accurate ("RefCell is already immutably borrowed"), as panics can also occur when trying to mutably borrow a RefCell that is already mutably borrowed. Technically, at the time of this writing, the `take` method is not in stable Rust, but will be in the next version (1.49) rust-lang/rust#71395 A rust-toolchain file has been added codifying the expectation that this crate targets stable Rust.
sylvestre
added a commit
to sylvestre/coreutils
that referenced
this issue
Jul 30, 2021
Drivers: rust-lang/rust#71395 rust-lang/rust#80470 needed by grcov
sylvestre
added a commit
to sylvestre/coreutils
that referenced
this issue
Jul 30, 2021
Drivers: rust-lang/rust#71395 rust-lang/rust#80470 needed by grcov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B-unstable
Blocker: Implemented in the nightly compiler and unstable.
C-tracking-issue
Category: A tracking issue for an RFC or an unstable feature.
Libs-Small
Libs issues that are considered "small" or self-contained
Libs-Tracked
Libs issues that are tracked on the team's project board.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
This is a tracking issue for
#![feature(refcell_take)]
.About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
RefCell::take
#71398The text was updated successfully, but these errors were encountered: