Cleanup more of rustdoc #79372
Merged
Cleanup more of rustdoc #79372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-cleanup
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
pickfire
reviewed
Nov 24, 2020
| @@ -124,7 +124,7 @@ crate fn try_inline( | |||
| let attrs = merge_attrs(cx, Some(parent_module), target_attrs, attrs_clone); | |||
|
|
|||
| cx.renderinfo.borrow_mut().inlined.insert(did); | |||
| let what_rustc_thinks = clean::Item::from_def_id_and_parts(did, Some(name), kind, cx); | |||
| let what_rustc_thinks = clean::Item::from_def_id_and_parts(did, Some(name.clean(cx)), kind, cx); | |||
There was a problem hiding this comment.
I haven't look deep but I wonder why do we need to have this .clean(cx) so many times unlike before?
There was a problem hiding this comment.
Does the explanation in the commit message help? bbded0b
There was a problem hiding this comment.
Yes, now I understand. I didn't know it is related to interning.
- Take `String` instead of `Symbol` - this avoids having to intern then immediately stringify the existing string. - Remove unused `get_stability` and `get_deprecation` - Remove unused `attrs` field from `primitives`
|
This is ready for review. |
GuillaumeGomez
approved these changes
Nov 26, 2020
|
Awesome as usual, thanks! @bors: r+ |
|
📌 Commit 09a3bc1 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 09a3bc1 with merge 77f09bb854d585c24f0e2bc98e35d7db33a6a293... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2020
Remove doctree::Macro and distinguish between `macro_rules!` and `pub macro` This is a part of rust-lang#78082, removing doctree::Macro. Uses the changes in rust-lang#79372 Fixes rust-lang#76761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item::from_def_idfor StructFieldfrom_def_id_and_partsfor primitives and keywordsStringinstead ofSymbolinfrom_def_id- this avoids having to intern then immediately stringify the existing string.get_stabilityandget_deprecationattrsfield fromprimitivesattrsfield fromkeywordsThis will probably conflict with #79335 and I would prefer for that PR to land first - I'm anxious for #77467 to land :)
Makes #76998 easier to add.
r? @GuillaumeGomez