Fix item name display on mobile #79936
Conversation
GuillaumeGomez
added
A-rustdoc-ui
|
Can you post some screenshots of how this looks at various screen widths? Maybe with different lengths of the summary too? |
|
Absolutely! Didn't because I just realized that the bug for the input was back. Fixing it once again... |
|
Ok, added the screenshot and also a fix for the not-clickable search input: the issue was that under 416px width, the search input goes below "inside" the |
|
@GuillaumeGomez pointed out to me that this only affects mobile, so I'm comfortable changing it even though it goes from I'd prefer for @Nemo157 to take a look at this before merging if possible, but otherwise LGTM. |
|
To add a bit more info: |
|
Another way of doing this on small screens is to put the left-aligned name above the documentation: **fn**
Function pointers, like `fn(usize) -> bool`.This would avoid 3-words width, making it more readable (I think) on mobile/narrower pages. |
|
Hmmmm... I'm not sure to like the idea. Considering the idea here is mostly fixing the bug, I think this goes a bit beyond. Could you open an issue suggesting this and linking to this PR so we can discuss it please? |
| @@ -1569,9 +1569,13 @@ h4 > .notable-traits { | |||
| height: 73px; | |||
| } | |||
|
|
|||
| #main { | |||
| margin-top: 100px; | |||
There was a problem hiding this comment.
This results in quite a big blank area on desktop
Ignore me, I missed the media query.
There was a problem hiding this comment.
I was about to comment and ask how you were able to achieve that result. 🤣
There was a problem hiding this comment.
Manually editing the css on doc.rust-lang.org wrong to test it 😅
There was a problem hiding this comment.
Just in this case, generally it works. ;)
|
LGTM |
|
@bors r=Nemo157,jyn514 |
|
📌 Commit 9c36491 has been approved by |
bors
added
the
S-waiting-on-bors
…laumeGomez Rollup of 3 pull requests Successful merges: - rust-lang#79918 (doc(array,vec): add notes about side effects when empty-initializing) - rust-lang#79936 (Fix item name display on mobile) - rust-lang#80013 (Refactor test_lang_string_parse to make it clearer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…, r=jyn514 Fix search section position on small devices Fixes rust-lang#79526. This is exactly the same issue fixed in 9c36491 (in rust-lang#79936) but applied to the search section. When the width becomes too small, the search input goes on its own line to get more space, making it go "under" the section following (so either "main" or "search"). The fix is to simply make the section go more under so that it doesn't go over the search input. r? `@jyn514`
Fixes rust-lang/docs.rs#1200
cc @jyn514
r? @Nemo157