-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #82053
Rollup of 8 pull requests #82053
Commits on Feb 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0488afd - Browse repository at this point
Copy the full SHA 0488afdView commit details
Commits on Feb 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0d96a79 - Browse repository at this point
Copy the full SHA 0d96a79View commit details
Commits on Feb 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 788e4bb - Browse repository at this point
Copy the full SHA 788e4bbView commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fcce998 - Browse repository at this point
Copy the full SHA fcce998View commit details -
Drop an unnecessary intermediate variable
Neither does it shorten the code nor does it provide a helpful name.
Configuration menu - View commit details
-
Copy full SHA for 28347eb - Browse repository at this point
Copy the full SHA 28347ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 715c19e - Browse repository at this point
Copy the full SHA 715c19eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 681ccca - Browse repository at this point
Copy the full SHA 681cccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95c984a - Browse repository at this point
Copy the full SHA 95c984aView commit details -
Add docs for shared_from_slice From impls
The advantage of making these docs is mostly in pointing out that these functions all make new allocations and copy/clone/move the source into them. These docs are on the function, and not the `impl` block, to avoid showing the "[+] show undocumented items" button. CC rust-lang#51430
Configuration menu - View commit details
-
Copy full SHA for 7fafa4d - Browse repository at this point
Copy the full SHA 7fafa4dView commit details
Commits on Feb 13, 2021
-
Added tests to drain an empty vec
Discovered this kind of issue in an unrelated library. The author copied the tests from here and AFAIK, there are no tests for this particular case. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fa9af6a - Browse repository at this point
Copy the full SHA fa9af6aView commit details -
Rollup merge of rust-lang#81811 - schteve:fix_vec_retain_doc_test, r=…
…m-ou-se Fix doc test for Vec::retain(), now passes clippy::eval_order_dependence Doc test for Vec::retain() works correctly but is flagged by clippy::eval_order_dependence. Fix avoids the issue by using an iterator instead of an index.
Configuration menu - View commit details
-
Copy full SHA for 4cb3810 - Browse repository at this point
Copy the full SHA 4cb3810View commit details -
Rollup merge of rust-lang#81900 - vandenheuvel:organize_trait_tests, …
…r=Mark-Simulacrum Organize trait test files Organizes trait tests in folders where reasonable and removes name redundancies.
Configuration menu - View commit details
-
Copy full SHA for a390206 - Browse repository at this point
Copy the full SHA a390206View commit details -
Rollup merge of rust-lang#81995 - 0yoyoyo:fix-issue-81650-explicit-li…
…fetime-error, r=estebank Fix suggestion to introduce explicit lifetime Addresses rust-lang#81650 Error message after fix: ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime #2 defined on the function body at 24:1... --> src/main.rs:24:1 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ```
Configuration menu - View commit details
-
Copy full SHA for 14b217c - Browse repository at this point
Copy the full SHA 14b217cView commit details -
Rollup merge of rust-lang#82031 - LingMan:unneeded_var, r=varkor
Drop an unnecessary intermediate variable Neither does it shorten the code nor does it provide a helpful name. `@rustbot` modify labels +C-cleanup +T-compiler r? `@varkor`
Configuration menu - View commit details
-
Copy full SHA for f6677b0 - Browse repository at this point
Copy the full SHA f6677b0View commit details -
Rollup merge of rust-lang#82033 - magurotuna:issue82016, r=jyn514
Refactor `get_word_attr` to return only `Option` This commit removes `bool` from the return type of `NestedAttributesExt::get_word_attr` so it will return only `Option<ast::NestedMetaItem>` for less redundancy. Closes rust-lang#82016 r? `@jyn514`
Configuration menu - View commit details
-
Copy full SHA for 4c8e38a - Browse repository at this point
Copy the full SHA 4c8e38aView commit details -
Rollup merge of rust-lang#82040 - GuillaumeGomez:ensure-src-link, r=C…
…raftSpider Add test to prevent src link regression Fixes rust-lang#80502. This PR is simply about adding a test to prevent a regression. cc `@bugadani` `@CraftSpider` r? `@camelid`
Configuration menu - View commit details
-
Copy full SHA for 3560ff3 - Browse repository at this point
Copy the full SHA 3560ff3View commit details -
Rollup merge of rust-lang#82041 - notriddle:shared-from-slice-docs, r…
…=m-ou-se Add docs for shared_from_slice From impls The advantage of making these docs is mostly in pointing out that these functions all make new allocations and copy/clone/move the source into them. These docs are on the function, and not the `impl` block, to avoid showing the "[+] show undocumented items" button. CC rust-lang#51430
Configuration menu - View commit details
-
Copy full SHA for 2673026 - Browse repository at this point
Copy the full SHA 2673026View commit details -
Rollup merge of rust-lang#82050 - hbina:fix/added-test-to-drain-empty…
…-vec, r=dtolnay Added tests to drain an empty vec Discovered this kind of issue in an unrelated library. The author copied the tests from here and AFAIK, there are no tests for this particular case. cmazakas/minivec#19 Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0ca5fd7 - Browse repository at this point
Copy the full SHA 0ca5fd7View commit details