Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert performance-sensitive change in #82436 #83293

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Commits on Mar 19, 2021

  1. Revert performance-sensitive change in rust-lang#82436

    This change was done in rust-lang#82436, as an "optimization". Unfortunately I
    missed that this code is not always executed, because of the "continue"
    in the conditional above it.
    
    This commit should solve the perf regressions introduced by rust-lang#82436 as I
    think there isn't anything else that could affect runtime performance in
    that PR. The `Pick` type grows only one word, which I doubt can cause up
    to 8.8% increase in RSS in some of the benchmarks.
    osa1 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    f925757 View commit details
    Browse the repository at this point in the history