Add download-rustc = "if-unchanged"
#83368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-enhancement
rust-highfive
added
the
S-waiting-on-review
This was referenced Mar 22, 2021
|
@Mark-Simulacrum do you know when you'll have a chance to look at this? It's an easy +12 -4, the only thing questionable is that it sets more env variables from bootstrap.py. |
|
r=me if the error message points at download-rustc somehow |
|
@bors r=Mark-Simulacrum |
|
📌 Commit 7f5964a has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 4, 2021
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? `@Mark-Simulacrum` cc `@camelid`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 4, 2021
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? ``@Mark-Simulacrum`` cc ``@camelid``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 4, 2021
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? ```@Mark-Simulacrum``` cc ```@camelid```
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 4, 2021
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? ````@Mark-Simulacrum```` cc ````@camelid````
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 5, 2021
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? `````@Mark-Simulacrum````` cc `````@camelid`````
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 5, 2021
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? ``````@Mark-Simulacrum`````` cc ``````@camelid``````
This was referenced Apr 5, 2021
jyn514
pushed a commit
to jyn514/rust
that referenced
this pull request
Apr 5, 2021
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? ```````@Mark-Simulacrum``````` cc ```````@camelid```````
|
Err oops, this disallows |
|
@bors r- |
bors
added
S-waiting-on-author
This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools.
jyn514
force-pushed
the
download-if-unchanged
branch
from
7f5964a
to
580a740
Compare
|
@bors r=Mark-Simulacrum |
|
📌 Commit 580a740 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#83368 (Add `download-rustc = "if-unchanged"`) - rust-lang#83705 (Give a better error when --theme is not a CSS file) - rust-lang#83853 (Disallow the use of high byte registes as operands on x86_64) - rust-lang#83877 (Remove unnecessary exceptions to the platform-specific code check) - rust-lang#83878 (Fix racing file access in tidy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 5, 2021
Add `x.py setup tools` which enables `download-rustc` by default Helps with rust-lang#81930. I know I said in that issue that I should fix that rebasing rebuilds bootstrap, but the compile time improvement is so good I think it's ok to leave that fix for later (I still plan to work on it). I think all the outright bugs have been fixed :) This builds on rust-lang#83368 so I can set the option to `if-unchanged`. r? `@Mark-Simulacrum`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 5, 2021
Add `x.py setup tools` which enables `download-rustc` by default Helps with rust-lang#81930. I know I said in that issue that I should fix that rebasing rebuilds bootstrap, but the compile time improvement is so good I think it's ok to leave that fix for later (I still plan to work on it). I think all the outright bugs have been fixed :) This builds on rust-lang#83368 so I can set the option to `if-unchanged`. r? ``@Mark-Simulacrum``
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 5, 2021
Add `x.py setup tools` which enables `download-rustc` by default Helps with rust-lang#81930. I know I said in that issue that I should fix that rebasing rebuilds bootstrap, but the compile time improvement is so good I think it's ok to leave that fix for later (I still plan to work on it). I think all the outright bugs have been fixed :) This builds on rust-lang#83368 so I can set the option to `if-unchanged`. r? ```@Mark-Simulacrum```
jyn514
added
the
A-download-rustc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows keeping the setting to a fixed value without having to
toggle it when you want to work on the compiler instead of on tools.
This sets
BOOTSTRAP_DOWNLOAD_RUSTCin bootstrap.py so rustbuild doesn't have to try and replicate its logic.Helps with #81930.
r? @Mark-Simulacrum cc @camelid