Improve fs error open_from unix #83522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One other place we could improve is rust/library/std/src/io/error.rs Line 132 in e423058 InvalidInput, but that is being used by quite a few different components, so not sure how to improve that even.
|
pickfire
commented
Mar 26, 2021
JohnTitor
reviewed
Mar 27, 2021
|
r=me once nits are addressed and commits are squashed. |
JohnTitor
added
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Consistency for rust-lang#79399 Suggested by JohnTitor Improve fs error invaild input for sys_common The text was duplicated from unix.
|
@bors r+ |
|
📌 Commit 6c6ef73 has been approved by |
bors
added
S-waiting-on-bors
|
@JohnTitor Note that I change the code to import from sys_common. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#81351 (combine: stop eagerly evaluating consts) - rust-lang#82525 (make unaligned_references future-incompat lint warn-by-default) - rust-lang#82626 (update array missing `IntoIterator` msg) - rust-lang#82917 (Add function core::iter::zip) - rust-lang#82993 (rustdoc: Use diagnostics for error when including sources) - rust-lang#83522 (Improve fs error open_from unix) - rust-lang#83548 (Always preserve `None`-delimited groups in a captured `TokenStream`) - rust-lang#83555 (Add #[inline] to io::Error methods) Failed merges: - rust-lang#83130 (escape_ascii take 2) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistency for #79399
Suggested by JohnTitor
r? @JohnTitor
Not user if the error is too long now, do we handle long errors well?