Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: Restore missing --bulk-dirs for rust-docs, rustc-docs #84289

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Apr 18, 2021

The --bulk-dirs argument was removed for rust-docs in commit c768ce1 and rustc-docs in commit 8ca46fc (#79788), presumably by mistake; that slowed down installation of rust-docs from under a second to some twenty minutes. Restoring --bulk-dirs reverses this slowdown.

Fixes #80684.

Cc @pietroalbini.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2021
The --bulk-dirs argument was removed for rust-docs in commit
c768ce1 and rustc-docs in commit
8ca46fc (rust-lang#79788), presumably by
mistake; that slowed down installation of rust-docs from under a
second to some twenty *minutes*.  Restoring --bulk-dirs reverses this
slowdown.

Fixes rust-lang#80684.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk changed the title bootstrap: Restore missing --bulk-dir for rust-docs, rustc-docs bootstrap: Restore missing --bulk-dirs for rust-docs, rustc-docs Apr 18, 2021
@jyn514 jyn514 added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 18, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Apr 22, 2021

📌 Commit 6dfd700 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2021
@bors
Copy link
Contributor

bors commented Apr 22, 2021

⌛ Testing commit 6dfd700 with merge 88b99de...

@bors
Copy link
Contributor

bors commented Apr 22, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 88b99de to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2021
@bors bors merged commit 88b99de into rust-lang:master Apr 22, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 22, 2021
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request May 5, 2021
Bug: https://bugs.gentoo.org/783468
X-Upstream-Issue: rust-lang/rust#80684
X-Upstream-Fix: rust-lang/rust#84289
Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
@andersk andersk deleted the bootstrap-bulk-dir branch August 6, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing docs with x.py install is very slow.
6 participants