Add test for suggestion to borrow unsized function parameters #84728

camelid · 2021-04-29T23:27:06Z

This is a regression test for #82820.

This test case is included in more general tests, but I think the error
regressed because there were a bunch of other diagnostic changes in the
test that obscured this regression.

Hopefully, having a test specific to the suggestion, and running rustfix
for the test, will prevent this error from regressing in the future.

rust-highfive · 2021-04-29T23:27:09Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

camelid · 2021-04-29T23:27:23Z

This PR is draft because I'm waiting for CI to fail so I can copy-paste the output.

camelid · 2021-04-30T20:17:55Z

Ok, CI should pass now.

hellow554 · 2021-05-03T07:05:15Z

Would it make sense to to add fn baz(_baz: str) as well, because how _ was handled differently than baz? Not sure, if there is a different codepath for underscore variables as well.

camelid · 2021-05-05T01:34:21Z

Done :)

Mark-Simulacrum · 2021-05-06T01:58:43Z

r=me once CI is fixed

This is a regression test for rust-lang#82820. This test case is included in more general tests, but I think the error regressed because there were a bunch of other diagnostic changes in the test that obscured this regression. Hopefully, having a test specific to the suggestion, and running rustfix for the test, will prevent this error from regressing in the future.

camelid · 2021-05-06T20:00:26Z

@bors r=@Mark-Simulacrum rollup

bors · 2021-05-06T20:00:27Z

📌 Commit a7500e5 has been approved by Mark-Simulacrum

Rollup of 11 pull requests Successful merges: - rust-lang#84409 (Ensure TLS destructors run before thread joins in SGX) - rust-lang#84500 (Add --run flag to compiletest) - rust-lang#84728 (Add test for suggestion to borrow unsized function parameters) - rust-lang#84734 (Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest) - rust-lang#84755 (Allow using `core::` in intra-doc links within core itself) - rust-lang#84871 (Disallows `#![feature(no_coverage)]` on stable and beta (using standard crate-level gating)) - rust-lang#84872 (Wire up tidy dependency checks for cg_clif) - rust-lang#84896 (Handle incorrect placement of parentheses in trait bounds more gracefully) - rust-lang#84905 (CTFE engine: rename copy → copy_intrinsic, move to intrinsics.rs) - rust-lang#84953 (Remove unneeded call to with_default_session_globals in rustdoc highlight) - rust-lang#84987 (small nits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

camelid added A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`. A-testsuite Area: The testsuite used to check the correctness of rustc labels Apr 29, 2021

rust-highfive assigned Mark-Simulacrum Apr 29, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2021

camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2021