Wire up tidy dependency checks for cg_clif #84872
Conversation
The comment says that build dependencies shouldn't matter unless they do some kind of codegen. It is safer to always check it though.
bjorn3
added
C-enhancement
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -44,12 +44,29 @@ const EXCEPTIONS: &[(&str, &str)] = &[ | |||
| ("fortanix-sgx-abi", "MPL-2.0"), // libstd but only for `sgx` target | |||
| ]; | |||
|
|
|||
| const EXCEPTIONS_CRANELIFT: &[(&str, &str)] = &[ | |||
| ("cranelift-bforest", "Apache-2.0 WITH LLVM-exception"), | |||
There was a problem hiding this comment.
This license is used by LLVM too, so it shouldn't be a problem.
| ("libloading", "ISC"), | ||
| ("mach", "BSD-2-Clause"), |
There was a problem hiding this comment.
Both of these licenses are equivalent to MIT I believe, but IANAL.
|
Would it potentially make sense to deduplicate the I'm thinking of two cases here:
|
|
There are two lists as there are two workspaces. Changing a single |
|
@bjorn3 Would it be feasible to merge the lists into one list that tags each dependency as needed for one, the other, or both? That seems like it'd simplify maintenance, and avoid additional CI cycles ("oops, I forgot to fix the backend I'm not using"). |
|
Running tidy will always check both the main workspace and cg_clif's workspace. Merging both lists doesn't change anything about that. The only change will be that it makes the list a bit harder to read I think. There is barely any overlap in dependencies between rustc and cg_clif anyway. |
|
@bjorn3 Ah, I see; I didn't realize that both lists would always get checked. In that case, this isn't a semantic issue, only a question of what's easier to maintain. Sorry for the noise, then. |
|
@bors r+ I think this PR is pretty much a strict improvement, though I want to be clear that this is not a confirmation of the license exceptions being OK - we'll want to evaluate those when we get closer to distributing cranelift, but for now this PR is still just an improvement of the status quo. Thanks! |
|
📌 Commit 24def63 has been approved by |
bors
added
S-waiting-on-bors
Wire up tidy dependency checks for cg_clif Also contains a fix and improvement to tidy. Required for rust-lang#81746.
Wire up tidy dependency checks for cg_clif Also contains a fix and improvement to tidy. Required for rust-lang#81746.
Rollup of 11 pull requests Successful merges: - rust-lang#84409 (Ensure TLS destructors run before thread joins in SGX) - rust-lang#84500 (Add --run flag to compiletest) - rust-lang#84728 (Add test for suggestion to borrow unsized function parameters) - rust-lang#84734 (Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest) - rust-lang#84755 (Allow using `core::` in intra-doc links within core itself) - rust-lang#84871 (Disallows `#![feature(no_coverage)]` on stable and beta (using standard crate-level gating)) - rust-lang#84872 (Wire up tidy dependency checks for cg_clif) - rust-lang#84896 (Handle incorrect placement of parentheses in trait bounds more gracefully) - rust-lang#84905 (CTFE engine: rename copy → copy_intrinsic, move to intrinsics.rs) - rust-lang#84953 (Remove unneeded call to with_default_session_globals in rustdoc highlight) - rust-lang#84987 (small nits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Also contains a fix and improvement to tidy.
Required for #81746.