Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move coverage tests from run-make-fulldeps to run-make #85007

Closed
wants to merge 2 commits into from
Closed

Move coverage tests from run-make-fulldeps to run-make #85007

wants to merge 2 commits into from

Commits on May 7, 2021

  1. Move coverage tests from run-make-fulldeps to run-make 

    Fixes: rust-lang#83830

The first commit was migrated from another PR that failed because CI had
errors likely resulting from trying to run the coverage tests in
run-make. (See: rust-lang#84797 (comment))

So moving the tests should be done as it's own separate PR.

To attempt to resolve those CI errors, this PR also updates bootstrap to
add LLVM library link path to run-make.

When moving coverage tests from run-make-fulldeps to run-make,
some targets failed in CI with an obscure message:

failed to execute command: "musl-g++" "-ffunction-sections"
"-fdata-sections" "-fPIC" "-m32" "-march=i686" "-Wl,-melf_i386"
"-static" "-Wa,-mrelax-relocations=no" "-print-file-name=libstdc++.a"

error: No such file or directory (os error 2)

The coverage tests include # needs-profiler-support and these are the
first run-make tests to require it (as far as I can tell).

There is a special case in bootstrap for adding the LLVM library link
path, and it applies to run-make-fulldeps. This commit adds it for
run-make as well.
    @richkadel
    richkadel committed May 7, 2021
    Copy the full SHA
    3e05c09 View commit details
    Browse the repository at this point in the history

  2. adding LLVM library link path to run-make 

    When moving `coverage` tests from `run-make-fulldeps` to `run-make`,
some targets failed in CI with an obscure message:

failed to execute command: "musl-g++" "-ffunction-sections"
"-fdata-sections" "-fPIC" "-m32" "-march=i686" "-Wl,-melf_i386"
"-static" "-Wa,-mrelax-relocations=no" "-print-file-name=libstdc++.a"

error: No such file or directory (os error 2)

The coverage tests include `# needs-profiler-support` and these are the
first `run-make` tests to require it (as far as I can tell).

There is a special case in `bootstrap` for adding the LLVM library link
path, and it applies to `run-make-fulldeps`. This commit adds it for
`run-make` as well.
    @richkadel
    richkadel committed May 7, 2021
    Copy the full SHA
    4881fc7 View commit details
    Browse the repository at this point in the history