Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coverage tests from run-make-fulldeps to run-make #85007

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bootstrap/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,7 @@ note: if you're sure you want to do this, please open an issue as to why. In the
.arg(builder.ensure(tool::JsonDocCk { compiler: json_compiler, target }));
}

if mode == "run-make" && suite.ends_with("fulldeps") {
if mode == "run-make" && !suite.ends_with("fulldeps") {
let rust_demangler = builder
.ensure(tool::RustDemangler { compiler, target, extra_features: Vec::new() })
.expect("in-tree tool");
Expand Down Expand Up @@ -1399,7 +1399,7 @@ note: if you're sure you want to do this, please open an issue as to why. In the
// requirement, but the `-L` library path is not propagated across
// separate compilations. We can add LLVM's library path to the
// platform-specific environment variable as a workaround.
if !builder.config.dry_run && suite.ends_with("fulldeps") {
if !builder.config.dry_run && (suite == "ui-fulldeps" || mode == "run-make") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be removed. We now know this did not fix the CI issues in the MUSL target.

let llvm_libdir = output(Command::new(&llvm_config).arg("--libdir"));
add_link_lib_path(vec![llvm_libdir.trim().into()], &mut cmd);
}
Expand Down
3 changes: 0 additions & 3 deletions src/test/run-make-fulldeps/coverage/compiletest-ignore-dir

This file was deleted.

6 changes: 0 additions & 6 deletions src/test/run-make-fulldeps/coverage/coverage_tools.mk

This file was deleted.

3 changes: 3 additions & 0 deletions src/test/run-make/coverage/compiletest-ignore-dir
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Directory "coverage" supports the tests at prefix ../coverage-*

# Use ./x.py [options] test src/test/run-make/coverage to run all related tests.
6 changes: 6 additions & 0 deletions src/test/run-make/coverage/coverage_tools.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Common Makefile include for Rust `run-make/coverage-* tests. Include this
# file with the line:
#
# -include ../coverage/coverage_tools.mk

-include ../../run-make-fulldeps/tools.mk