rustdoc: Print a warning if the diff when comparing to old nightlies is empty #85997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
A-testsuite
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-contributor-roadblock
This comment has been minimized.
This comment has been minimized.
…is empty This avoids confusing situations where it's unclear whether there's a bug in the diff tool or not: ``` 26: @Has check failed `XPATH PATTERN` did not match // @Has - '//code/a[@href="{{channel}}/std/primitive.i32.html"]' 'i32' Encountered 6 errors ------------------------------------------ info: generating a diff against nightly rustdoc failures: [rustdoc] rustdoc/primitive-reexport.rs ```
jyn514
added
the
S-waiting-on-review
|
@bors r+ rollup Seems OK as an improvement. I'm a bit worried by the allegedly nightly (though I see no record of that, we seem to just invoke whatever rustdoc we happen to find, and on Windows especially that's pretty likely to be the newly built rustdoc I'd expect, as it's easy for the bin directory to end up in PATH there) rustdoc. I'm not sure if I expressed similar concerns before or what the purpose of this code is, but it seems surprising. |
|
📌 Commit 2430ede has been approved by |
bors
added
S-waiting-on-bors
|
Yeah, I do want to change it to download a version from CI at some point (maybe reusing the logic from download-rustc?) but I haven't gotten around to it yet. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 10, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#82037 (Make symbols stripping work on MacOS X) - rust-lang#84687 (Multiple improvements to RwLocks) - rust-lang#85997 (rustdoc: Print a warning if the diff when comparing to old nightlies is empty) - rust-lang#86051 (Updated code examples and wording in move keyword documentation ) - rust-lang#86111 (fix off by one in `std::iter::Iterator` documentation) - rust-lang#86113 (build doctests with lld if use-lld = true) - rust-lang#86175 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids confusing situations where it's unclear whether there's a
bug in the diff tool or not: