Rollup of 8 pull requests #86348
Merged
Rollup of 8 pull requests #86348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some awkward wording in the `core::option` documentation in the "Options and pointers" section.
Fix a typo/missed replacement in the documentation for `impl From<&Option<T>> for Option<&T>` in `core::option`.
Previously, coverage tests were writing profiler data to files based on their pid. As rustdoc spawns each doctest as its own process, it might be possible in rare cases that a pid is being reused which would cause a file to be overwritten, leading to incorrect coverage results.
Avoid possible filename collision in coverage tests Previously, coverage tests were writing profiler data to files based on their pid. As rustdoc spawns each doctest as its own process, it might be possible in rare cases that a pid is being reused which would cause a file to be overwritten, leading to incorrect coverage results. should help with rust-lang#83262 r? `@tmandry`
Updates `Clone` docs for `Copy` comparison. Quite a few people (myself included) have come under the impression that the difference between `Copy` and `Clone` is that `Copy` is cheap and `Clone` is expensive, where the actual difference is that `Copy` constrains the type to bit-wise copying, and `Clone` allows for more expensive operations. The source of this misconception is in the `Clone` docs, where the following line is in the description: > Differs from `Copy` in that `Copy` is implicit and extremely inexpensive, while `Clone` is always explicit and may or may not be expensive. The `Clone` documentation page also comes up before the `Copy` page on google when searching for "the difference between `Clone` and `Copy`". This PR updates the documentation to clarify that "extremely inexpensive" means an "inexpensive bit-wise copy" to hopefully prevent future rust users from falling into this misunderstanding.
fix minor wording/typo issues in core::option docs These are just minor wording or typo things I came across while making other edits.
…ce, r=oli-obk rustdoc- dont ICE on `ConstEvaluatable` predicates Fixes rust-lang#77647 rustdoc doesn't need to be handling these as you cant write them, they just get added implicitly when you write a where clause containing an expression.
Add a regression test for issue-76510 Fixed by rust-lang#78407, closes rust-lang#76510 r? ``@oli-obk``
…, r=jsha Allow to run only a few GUI tests It allows to specify only one (or more) GUI tests. Considering the tests are not super fast to run, this is very useful for development. cc `@Mark-Simulacrum` r? `@jsha`
Don't mark "safe" intrinsics as unsafe A good example of this is [intrinsics::abort](https://doc.rust-lang.org/nightly/core/intrinsics/fn.abort.html). Before:  After:  cc ``@jyn514`` r? ``@lqd``
…s, r=Mark-Simulacrum Remove some duplicate `char` assoc items on RELEASES.md They were stabilized on 1.52 but 1.53's note also has them mistakenly. Originally reported on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/incorrect.20relnotes).
|
@bors r+ rollup=never p=8 |
|
📌 Commit 59ffa34 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Clonedocs forCopycomparison. #86200 (UpdatesClonedocs forCopycomparison.)ConstEvaluatablepredicates #86242 (rustdoc- dont ICE onConstEvaluatablepredicates)charassoc items on RELEASES.md #86345 (Remove some duplicatecharassoc items on RELEASES.md)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup