chore(rustdoc): Remove unused impl block #86561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thank you! I've often wondered why the compiler doesn't warn about unused impls even when the type is private ... @bors r+ rollup |
|
📌 Commit e629381 has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
C-cleanup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#86137 (Error code cleanup and enforce checks) - rust-lang#86296 (Add documentation for various THIR structs) - rust-lang#86415 (Document associativity of iterator folds.) - rust-lang#86533 (Support lowercase error codes in `--explain`) - rust-lang#86536 (Edition 2021 enables disjoint capture) - rust-lang#86560 (Update cargo) - rust-lang#86561 (chore(rustdoc): Remove unused impl block) - rust-lang#86566 (Use `use_verbose` for `mir::Constant`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 25, 2021
…, r=jyn514 chore(rustdoc): remove unused members of RenderType PR rust-lang#86561 removes the only place the `generics` member is read. This PR does even more cleanup.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 25, 2021
…, r=jyn514 chore(rustdoc): remove unused members of RenderType PR rust-lang#86561 removes the only place the `generics` member is read. This PR does even more cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.