Don't dist miri or rust-analyzer on stable or beta. #86568
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! Do we have any other nightly-only tools? |
|
rust-analyzer-preview is also nightly-only. |
Any things that is |
|
Not really, the only nightly-only components are |
Yea, my bad, but it's also seems that If nightly-only components are |
Mark-Simulacrum
added
the
beta-accepted
|
I added rust-analyzer.
I believe the components start as "preview", but due to some renaming issue in rustup, there is a "renames" table in the manifest to drop the preview. I don't recall the exact reason it does it that way, possibly due to backwards compatibility? |
ehuss
changed the title
|
@bors r+ rollup |
|
📌 Commit 6aa79a3 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - rust-lang#86206 (Fix type checking of return expressions outside of function bodies) - rust-lang#86358 (fix pretty print for `loop`) - rust-lang#86568 (Don't dist miri or rust-analyzer on stable or beta.) - rust-lang#86683 (:arrow_up: rust-analyzer) - rust-lang#86687 (Allow anyone to set `perf-regression` label) - rust-lang#86688 (Add a regression test for issue-65384) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
(Bumping milestone to 1.54 -- this was backported in #86413 |
|
I backported the two patches from this pull request to 1.53.0 (trying to fix #86436), but now the build fails with: |
|
Please file a new issue for that - looks like x.py install likely needs to be similarly updated like in this PR, and that just hasn't happened yet. |
ehuss
added
the
beta-nominated
Mark-Simulacrum
removed
the
beta-nominated
|
Dropping beta-nominated; this was already backported in #86413 |
…Mark-Simulacrum Fix rust-analyzer install when not available. This changes it so that `x.py install` won't fail if rust-analyzer isn't available. This was changed in rust-lang#86568 to handle the case where installing on stable/beta, and `extended=true`, to skip rust-analyzer. But I neglected to update the install part to also ignore it. Fixes rust-lang#86999
miri fails if there's no git repository anywhere in directory tree however miri and rust-analyzer were not supposed to be built on stable channel in the first place: rust-lang/rust#86568 rust-lang/rust#87007
This prevents miri and rust-analyzer from being built for "dist" or "install" on the stable/beta channels. It is a nightly-only tool and should not be included.
Closes #86286