Add GUI test for "go to first" feature #87102
Merged
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
changed the title
GuillaumeGomez
force-pushed
the
go-to-first-feature
branch
from
7fd88e3
to
5f143d9
Compare
Manishearth
approved these changes
Jul 13, 2021
|
|
||
| // First, we check that the first page doesn't have the string we're looking for to ensure | ||
| // that the feature is changing page as expected. | ||
| goto: file://|DOC_PATH|/test_docs/index.html |
There was a problem hiding this comment.
should we also go to a search page without go_to_first?
There was a problem hiding this comment.
There is search-result-description.goml which does that already. :)
There was a problem hiding this comment.
Pop in a comment saying that and r=me
There was a problem hiding this comment.
Actually the test will be more complete if we add that as an intermediate check.
GuillaumeGomez
force-pushed
the
go-to-first-feature
branch
2 times, most recently
from
c514be3
to
87e648a
Compare
notriddle
approved these changes
Jul 13, 2021
|
@bors r+ rollup=maybe |
|
📌 Commit 87e648a927c1d5aa224bad075cedc195e984328c has been approved by |
bors
added
S-waiting-on-bors
notriddle
reviewed
Jul 13, 2021
GuillaumeGomez
force-pushed
the
go-to-first-feature
branch
from
87e648a
to
cac0d71
Compare
|
@bors: r=Manisheart,notriddle |
|
📌 Commit cac0d71 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 13, 2021
… r=Manisheart,notriddle Add GUI test for "go to first" feature It adds a test for rust-lang#85876 to ensure the feature is working as expected and prevent potential regression. cc `@jeanlucthumm` r? `@Manishearth`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 13, 2021
… r=Manisheart,notriddle Add GUI test for "go to first" feature It adds a test for rust-lang#85876 to ensure the feature is working as expected and prevent potential regression. cc ``@jeanlucthumm`` r? ``@Manishearth``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#87085 (Search result colors) - rust-lang#87090 (Make BTreeSet::split_off name elements like other set methods do) - rust-lang#87098 (Unignore some pretty printing tests) - rust-lang#87099 (Upgrade `cc` crate to 1.0.69) - rust-lang#87101 (Suggest a path separator if a stray colon is found in a match arm) - rust-lang#87102 (Add GUI test for "go to first" feature) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds a test for #85876 to ensure the feature is working as expected and prevent potential regression.
cc @jeanlucthumm
r? @Manishearth