Remove the aarch64 crypto target_feature
#87729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit e817b50 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 3, 2021
…=Amanieu Remove the aarch64 `crypto` target_feature The subfeatures `aes` or `sha2` should be used instead. This can't yet be done for ARM targets as some LLVM intrinsics still require `crypto`. Also update the runtime feature detection tests in `library/std` to mirror the updates in `stdarch`. This also helps rust-lang#86941 r? `@Amanieu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 3, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#81797 (Add `core::stream::from_iter`) - rust-lang#87267 (Remove space after negative sign in Literal to_string) - rust-lang#87663 (Rustdoc accessibility: use an icon for the [-]/[+] controls) - rust-lang#87720 (don't use .into() to convert types to identical types (clippy::useless_conversion)) - rust-lang#87723 (Use .contains instead of manual reimplementation.) - rust-lang#87729 (Remove the aarch64 `crypto` target_feature) - rust-lang#87731 (Update cargo) - rust-lang#87734 (Test dropping union fields more) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Aug 26, 2021
It was removed from the nightly compiler in this PR: rust-lang/rust#87729 This crate attempts to provide a 1:1 mapping of CPU feature detection to rustc's own target features, so this PR accordingly removes it. Breaking change; will require a minor version bump.
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Aug 26, 2021
It was removed from the nightly compiler in this PR: rust-lang/rust#87729 This crate attempts to provide a 1:1 mapping of CPU feature detection to rustc's own target features, so this PR accordingly removes it. Breaking change; will require a minor version bump.
tarcieri
added a commit
to RustCrypto/universal-hashes
that referenced
this pull request
Aug 27, 2021
It was removed from the nightly compiler: rust-lang/rust#87729
tarcieri
added a commit
to RustCrypto/universal-hashes
that referenced
this pull request
Aug 27, 2021
It was removed from the nightly compiler: rust-lang/rust#87729
github-actions bot
pushed a commit
to gnoliyil/fuchsia
that referenced
this pull request
Mar 7, 2022
Something changed recently in rustc that causes it to generate warnings when building for arm64 targets. This appears related to rust-lang/rust#87729 (though that PR is dated), which indicates that rustc is removing the crypto target and replacing it with "aes or sha2". This PR adds both, and removes crypto, for Rust only. (This does not work with clang (cflags). Change-Id: I438e2d3ae230fb512c7c864d775537ce4dd797f4 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/654243 Reviewed-by: Chris Tam <godtamit@google.com> Fuchsia-Auto-Submit: Rich Kadel <richkadel@google.com> Reviewed-by: Tyler Mandry <tmandry@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subfeatures
aesorsha2should be used instead.This can't yet be done for ARM targets as some LLVM intrinsics still require
crypto.Also update the runtime feature detection tests in
library/stdto mirror the updates instdarch. This also helps #86941r? @Amanieu